Add menu option for disabling app notifications

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1426 matching lines @@
   SetIsIncognitoEnabled(id, extension_sync_data.incognito_enabled());
   extension = NULL;  // No longer safe to use.
 
   if (extension_installed) {
     // If the extension is already installed, check if it's outdated.
     if (result < 0) {
       // Extension is outdated.
       bundle.pending_sync_data[extension_sync_data.id()] = extension_sync_data;
       CheckForUpdatesSoon();
     }
+    if (extension_sync_data.notifications_disabled() !=
+        extension_prefs_->IsAppNotificationDisabled(id))
+      extension_prefs_->SetAppNotificationDisabled(
+          id, extension_sync_data.notifications_disabled());

[Finnur, 2011/12/05 16:15:16]

Wait... Isn't one possibility here that app notifications is disabled for one
id, but extension sync data is enabled, so we flip the enabled bit for this id
to true?

Also, nit: Multi-line if clause, needs braces.

[asargent_no_longer_on_chrome, 2011/12/05 17:42:39]

|extension_sync_data| is specific to a particular extension (it's an object
encapsulating the state we push around via sync like enabled/disabled, allow in
incognito, etc.). Note that we grab |id| from it up above in this function.
 
Done.

   } else {
     // TODO(akalin): Replace silent update with a list of enabled
     // permissions.
     const bool kInstallSilently = true;
     if (!pending_extension_manager()->AddFromSync(
             id,
             extension_sync_data.update_url(),
             bundle.filter,
             kInstallSilently)) {
       LOG(WARNING) << "Could not add pending extension for " << id;
@@ skipping 1064 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }