Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.cc

Issue 8785015: Revert 112815 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/process_commit_response_command.cc
===================================================================
--- chrome/browser/sync/engine/process_commit_response_command.cc (revision 112854)
+++ chrome/browser/sync/engine/process_commit_response_command.cc (working copy)
@@ -4,7 +4,6 @@
#include "chrome/browser/sync/engine/process_commit_response_command.h"
-#include <cstddef>
#include <set>
#include <string>
#include <vector>
@@ -60,27 +59,6 @@
ProcessCommitResponseCommand::ProcessCommitResponseCommand() {}
ProcessCommitResponseCommand::~ProcessCommitResponseCommand() {}
-std::set<ModelSafeGroup> ProcessCommitResponseCommand::GetGroupsToChange(
- const sessions::SyncSession& session) const {
- std::set<ModelSafeGroup> groups_with_commits;
- syncable::ScopedDirLookup dir(session.context()->directory_manager(),
- session.context()->account_name());
- if (!dir.good()) {
- LOG(ERROR) << "Scoped dir lookup failed!";
- return groups_with_commits;
- }
-
- syncable::ReadTransaction trans(FROM_HERE, dir);
- const StatusController& status = session.status_controller();
- for (size_t i = 0; i < status.commit_ids().size(); ++i) {
- groups_with_commits.insert(
- GetGroupForModelType(status.GetUnrestrictedCommitModelTypeAt(i),
- session.routing_info()));
- }
-
- return groups_with_commits;
-}
-
bool ProcessCommitResponseCommand::ModelNeutralExecuteImpl(
sessions::SyncSession* session) {
ScopedDirLookup dir(session->context()->directory_manager(),

Powered by Google App Engine
This is Rietveld 408576698