Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 8785011: Protect status_area_ access (Closed)

Created:
9 years ago by stevenjb
Modified:
9 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Protect status_area_ access Change-Id: Ie6ee3ec84c126f46cdc34aea17bafa43cd49245c BUG=chromium-os:23709 TEST=Chrome starts + VMTests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
LGTM
9 years ago (2011-12-02 23:58:38 UTC) #1
stevenjb
This was subtle. Thanks to derat@ for the stack trace. In the new code we ...
9 years ago (2011-12-03 00:00:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8785011/1
9 years ago (2011-12-03 00:01:37 UTC) #3
commit-bot: I haz the power
Change committed as 112845
9 years ago (2011-12-03 01:54:42 UTC) #4
Nikita (slow)
Thanks for the fix!
9 years ago (2011-12-05 10:43:04 UTC) #5
Nikita (slow)
9 years ago (2011-12-05 10:57:55 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698