Issue 8785009: Fix AutoResize test and restore origin constants.

jennb

http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (left): http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode844 chrome/browser/ui/panels/panel_browsertest.cc:844: set_testing_work_area(gfx::Rect(0, 0, 1200, 900)); This doesn't change the work ...

9 years ago (2011-12-02 22:57:34 UTC) #1

levin

On 2011/12/02 22:57:34, jennb wrote: > http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc > File chrome/browser/ui/panels/panel_browsertest.cc (left): > > http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode844 > ...

9 years ago (2011-12-02 23:01:35 UTC) #2

levin

http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (left): http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode844 chrome/browser/ui/panels/panel_browsertest.cc:844: set_testing_work_area(gfx::Rect(0, 0, 1200, 900)); On 2011/12/02 22:57:34, jennb wrote: ...

9 years ago (2011-12-02 23:06:47 UTC) #3

jennb

http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (left): http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode844 chrome/browser/ui/panels/panel_browsertest.cc:844: set_testing_work_area(gfx::Rect(0, 0, 1200, 900)); On 2011/12/02 23:06:47, levin wrote: ...

9 years ago (2011-12-02 23:23:46 UTC) #4

jennb

Try bot result: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/6098

9 years ago (2011-12-03 00:27:34 UTC) #5

levin

On 2011/12/02 23:23:46, jennb wrote: > http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc > File chrome/browser/ui/panels/panel_browsertest.cc (left): > > http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode844 > ...

9 years ago (2011-12-03 00:42:49 UTC) #6

jennb

On 2011/12/03 00:42:49, levin wrote: > On 2011/12/02 23:23:46, jennb wrote: > > > http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_browsertest.cc ...

9 years ago (2011-12-03 01:36:09 UTC) #7

jennb

9 years ago (2011-12-03 01:36:25 UTC) #8

On 2011/12/03 01:36:09, jennb wrote:
> On 2011/12/03 00:42:49, levin wrote:
> > On 2011/12/02 23:23:46, jennb wrote:
> > >
> >
>
http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_...
> > > File chrome/browser/ui/panels/panel_browsertest.cc (left):
> > > 
> > >
> >
>
http://codereview.chromium.org/8785009/diff/1/chrome/browser/ui/panels/panel_...
> > > chrome/browser/ui/panels/panel_browsertest.cc:844:
> > > set_testing_work_area(gfx::Rect(0, 0, 1200, 900));
> > > On 2011/12/02 23:06:47, levin wrote:
> > > > On 2011/12/02 22:57:34, jennb wrote:
> > > > > This doesn't change the work area. Just changes a member variable in
the
> > > base
> > > > > class.  Oops.
> > > > I wonder why this method exists. It appears to have been added here:
> > > > http://src.chromium.org/viewvc/chrome?view=rev&revision=109588
> > > > 
> > > > but I don't see it being used there.
> > > 
> > > It's used in that test to set the value to 0 so that we don't customize
the
> > work
> > > area in that one particular test. Guess that method needs a better name. I
> > would
> > > prefer to rename it in a different patch and keep this one small, if
that's
> ok
> > > with you?
> > 
> > Yes, of course!
> 
> Is that a LGTM? ;-)

Sorry, didn't see the earlier email.

Issue 8785009: Fix AutoResize test and restore origin constants. (Closed)

Description

Patch Set 1 #

Messages