Issue 8785008: Simplify AudioRendererImpl by using AudioDevice.

Issue 8785008: Simplify AudioRendererImpl by using AudioDevice. (Closed)

Created:
9 years ago by vrk (LEFT CHROMIUM)

Modified:
9 years ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify AudioRendererImpl by using AudioDevice. This helps us move closer to being able to do renderer-side mixing, for improved performance. See original CL for discussion: http://codereview.chromium.org/8477037/ BUG=none TEST=audio_renderer_impl_unittest (also verified that the media layout tests all pass, and did manual testing with several audio files and YouTube videos) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113821

Patch Set 1 #

Patch Set 2 : Issue 8477037 patchset 6 #

Patch Set 3 : Changes based on latest round of comments #

Total comments: 2

Patch Set 4 : Rebase + CR response #

Patch Set 5 : Update stale comment #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -717 lines)			Patch
M	content/renderer/media/audio_device.h	View	1 2 3 4	7 chunks	+66 lines, -11 lines	0 comments	Download
M	content/renderer/media/audio_device.cc	View	1 2 3	9 chunks	+133 lines, -33 lines	0 comments	Download
M	content/renderer/media/audio_renderer_impl.h	View	1 2 3	6 chunks	+25 lines, -127 lines	0 comments	Download
M	content/renderer/media/audio_renderer_impl.cc	View		3 chunks	+112 lines, -390 lines	0 comments	Download
M	content/renderer/media/audio_renderer_impl_unittest.cc	View	1 2 3	8 chunks	+1 line, -154 lines	0 comments	Download
M	media/filters/audio_renderer_base.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

LGTM http://codereview.chromium.org/8785008/diff/3001/content/renderer/media/audio_renderer_impl_unittest.cc File content/renderer/media/audio_renderer_impl_unittest.cc (right): http://codereview.chromium.org/8785008/diff/3001/content/renderer/media/audio_renderer_impl_unittest.cc#newcode75 content/renderer/media/audio_renderer_impl_unittest.cc:75: static void SetUpTestCase() {} Can we remove this ...

9 years ago (2011-12-07 17:13:22 UTC) #1

vrk (LEFT CHROMIUM)

http://codereview.chromium.org/8785008/diff/3001/content/renderer/media/audio_renderer_impl_unittest.cc File content/renderer/media/audio_renderer_impl_unittest.cc (right): http://codereview.chromium.org/8785008/diff/3001/content/renderer/media/audio_renderer_impl_unittest.cc#newcode75 content/renderer/media/audio_renderer_impl_unittest.cc:75: static void SetUpTestCase() {} On 2011/12/07 17:13:22, acolwell wrote: ...

9 years ago (2011-12-09 00:16:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/8785008/12007

9 years ago (2011-12-09 00:16:31 UTC) #3

commit-bot: I haz the power

Try job failure for 8785008-12007 (retry) on linux_rel for step "browser_tests". It's a second try, ...

9 years ago (2011-12-09 01:32:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/8785008/12007

9 years ago (2011-12-09 01:44:19 UTC) #5

commit-bot: I haz the power

9 years ago (2011-12-09 02:33:46 UTC) #6

Try job failure for 8785008-12007 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Expand Messages | Collapse Messages