Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 8785007: Prerenders that send an OpenURL are canceled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cancel on OpenURL Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index e1e197f9711808ed29beae1f5ddc2081aa524c66..cc720d27d663da6718dea1f8b75745f83b37a571 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -88,6 +88,19 @@ class PrerenderContents::TabContentsDelegateImpl
prerender_contents_(prerender_contents) {
}
+ virtual TabContents* OpenURLFromTab(TabContents* source,
+ const OpenURLParams& params) {
mmenke 2011/12/05 15:28:25 nit: OVERRIDE
cbentzel 2011/12/05 15:30:59 Done.
+ // |OpenURLFromTab| is typicalled called when a frame performs a navigation
dominich 2011/12/05 14:40:41 nit: typically called :)
cbentzel 2011/12/05 15:30:21 Done.
+ // that requires the browser to perform the transition instead of WebKit.
+ // Examples include prerendering a site that redirects to an app URL,
+ // or if --enable-strict-site-isolation is specified and the prerendered
+ // frame redirects to a different origin.
+ // TODO(cbentzel): Consider supporting this is if it is a common case
+ // during prerenders.
+ prerender_contents_->Destroy(FINAL_STATUS_OPEN_URL);
+ return NULL;
+ }
+
// TabContentsDelegate implementation:
virtual bool ShouldAddNavigationToHistory(
const history::HistoryAddPageArgs& add_page_args,
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_final_status.h » ('j') | chrome/browser/prerender/prerender_final_status.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698