Prerenders that send an OpenURL are canceled.

Prerenders that send a ViewHostMsg_OpenURL are canceled with FINAL_STATUS_OPEN_URL.

This message is sent when a navigation is initiated from a renderer but requires browser intervention, typically because a new render process will be created. Examples of where this happens are redirects from a "normal page" to a hosted app domain, or transitions from one origin to another when --enable-strict-site-isolation is specified.

BUG=105972
TEST=Install YouTube app. Start Chrome with --prerender=enabled. Go to prerender-test.appspot.com, and prerender youtube.com. Click on it and www.youtube.com should appear. Check chrome://net-internals#prerender and make sure that the youtube prerender was canceled with OpenURL as the final status.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113011

[cbentzel, 2011-12-04 21:40:25]

I'm working on browser tests, but I'd like to get this behavior in for M17. It's
better than before, which would just show a blank page and require the user to
reload.

[dominich, 2011-12-05 14:40:41]

LGTM

I'm curious to see how often this happens as it would be a shame to not
prerender apps when they've been installed.

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_contents.cc:93: // |OpenURLFromTab| is
typicalled called when a frame performs a navigation
nit: typically called :)

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_final_status.h (right):

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_final_status.h:55: FINAL_STATUS_OPEN_URL =
40,
Remember to add this to the enum list in the histograms.xml file.

[mmenke, 2011-12-05 15:28:25]

LGTM

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_contents.cc:92: const OpenURLParams& params)
{
nit:  OVERRIDE

[cbentzel, 2011-12-05 15:30:21]

I agree that we need to monitor how frequently this happens.

Note that this doesn't happen if the prerender is directly for an app - i.e.
this won't get triggered if we prerender www.youtube.com when a hosted app is
installed for www.youtube.com.

The problem is when the prerendered page navigates into an app - such as when
youtube.com is prerendered, since it navigates into www.youtube.com.

If we want to successfully handle that case, we'll need to take care of spawning
a new process, setting it to be prerendered, and do all of the other things we
do in StartPrerendering.

This change is preferable to the existing behavior, which simply displays a
blank page.

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_contents.cc:93: // |OpenURLFromTab| is
typicalled called when a frame performs a navigation
On 2011/12/05 14:40:41, dominich wrote:
> nit: typically called :)

Done.

[cbentzel, 2011-12-05 15:30:59]

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_contents.cc (right):

http://codereview.chromium.org/8785007/diff/2001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_contents.cc:92: const OpenURLParams& params)
{
On 2011/12/05 15:28:25, Matt Menke wrote:
> nit:  OVERRIDE

Done.

[commit-bot: I haz the power, 2011-12-05 18:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/8785007/9001

[commit-bot: I haz the power, 2011-12-05 20:30:24]

Change committed as 113011