Badge Windows profile shortcuts with multi-user avatar.

chrome/installer/util/shell_util.cc

Index: chrome/installer/util/shell_util.cc
===================================================================
--- chrome/installer/util/shell_util.cc	(revision 112717)
+++ chrome/installer/util/shell_util.cc	(working copy)
@@ -547,6 +547,8 @@
                                             const std::wstring& description,
                                             const std::wstring& appended_name,
                                             const std::wstring& arguments,
+                                            const std::wstring& icon_path,
+                                            int icon_index,
                                             ShellChange shell_change,
                                             bool alternate,
                                             bool create_new) {
@@ -573,6 +575,8 @@
                                               shortcut.value(),
                                               arguments,
                                               description,
+                                              icon_path,
+                                              dist->GetIconIndex(),

[grt (UTC plus 2), 2011/12/03 04:14:00]

this should be icon_index, no?

[SteveT, 2011/12/03 05:07:09]

Yup, thanks for catching that.

                                               create_new);
       }
     }
@@ -585,6 +589,8 @@
                                             shortcut.value(),
                                             arguments,
                                             description,
+                                            icon_path,
+                                            dist->GetIconIndex(),

[grt (UTC plus 2), 2011/12/03 04:14:00]

same

[SteveT, 2011/12/03 05:07:09]

Done.

                                             create_new);
     }
   } else {
@@ -608,7 +614,9 @@
     if (ShellUtil::GetQuickLaunchPath(false, &user_ql_path)) {
       file_util::AppendToPath(&user_ql_path, shortcut_name);
       ret = ShellUtil::UpdateChromeShortcut(dist, chrome_exe, user_ql_path,
-                                            L"", L"", create_new);
+                                            L"", L"", chrome_exe,
+                                            dist->GetIconIndex(),
+                                            create_new);
     } else {
       ret = false;
     }
@@ -621,7 +629,9 @@
     if (ShellUtil::GetQuickLaunchPath(true, &default_ql_path)) {
       file_util::AppendToPath(&default_ql_path, shortcut_name);
       ret = ShellUtil::UpdateChromeShortcut(dist, chrome_exe, default_ql_path,
-                                            L"", L"", create_new) && ret;
+                                            L"", L"", chrome_exe,
+                                            dist->GetIconIndex(),
+                                            create_new) && ret;
     } else {
       ret = false;
     }
@@ -1052,13 +1062,14 @@
                                      const std::wstring& shortcut,
                                      const std::wstring& arguments,
                                      const std::wstring& description,
+                                     const std::wstring& icon_path,
+                                     int icon_index,
                                      bool create_new) {
   std::wstring chrome_path = FilePath(chrome_exe).DirName().value();
 
   FilePath prefs_path(chrome_path);
   prefs_path = prefs_path.AppendASCII(installer::kDefaultMasterPrefs);
   installer::MasterPreferences prefs(prefs_path);
-  int icon_index = dist->GetIconIndex();
   prefs.GetInt(installer::master_preferences::kChromeShortcutIconIndex,

[grt (UTC plus 2), 2011/12/03 04:14:00]

should this pref only do anything if
FilePath::CompareEqualIgnoreCase(icon_path.value(), chrome_exe.value())?  it
doesn't seem to make any sense otherwise.

[SteveT, 2011/12/03 05:09:53]

Yup, that makes sense. I am going to check
FilePath::CompareEqualIgnoreCase(icon_path, chrome_exe) for now, since those
values come in as wstrings. This is going to make the non-windows compilers
unhappy because of the annoying StringType def in FilePath, so I'll have to
address that next...

                &icon_index);
   if (create_new) {
@@ -1068,7 +1079,7 @@
         chrome_path.c_str(),               // working dir
         arguments.c_str(),                 // arguments
         description.c_str(),               // description
-        chrome_exe.c_str(),                // icon file
+        icon_path.c_str(),                 // icon file
         icon_index,                        // icon index
         dist->GetBrowserAppId().c_str());  // app id
   } else {
@@ -1078,7 +1089,7 @@
         chrome_path.c_str(),               // working dir
         arguments.c_str(),                 // arguments
         description.c_str(),               // description
-        chrome_exe.c_str(),                // icon file
+        icon_path.c_str(),                 // icon file
         icon_index,                        // icon index
         dist->GetBrowserAppId().c_str());  // app id
   }