ui/gfx/icon_util.cc - Issue 8785006: Badge Windows profile shortcuts with multi-user avatar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/icon_util.cc

Issue 8785006: Badge Windows profile shortcuts with multi-user avatar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Added a missing NULL check to icon_util. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/icon_util.cc

===================================================================

--- ui/gfx/icon_util.cc (revision 112717)

+++ ui/gfx/icon_util.cc (working copy)

@@ -243,7 +243,7 @@

base::win::ScopedHandle icon_file(::CreateFile(icon_path.value().c_str(),

GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL));

- if (icon_file.Get() == INVALID_HANDLE_VALUE)

+ if (icon_file.Get() == INVALID_HANDLE_VALUE || icon_file.Get() == NULL)

grt (UTC plus 2) 2011/12/05 14:48:27 what you really want here is: if (!icon_file.IsVal

SteveT 2011/12/05 15:24:46 Cool, thanks.

return false;

// Creating a set of bitmaps corresponding to the icon images we'll end up