Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 8785004: Change NavigationController::LoadURL to take a Referrer class instead of a GURL as referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_manager_unittest.cc
diff --git a/content/browser/debugger/devtools_manager_unittest.cc b/content/browser/debugger/devtools_manager_unittest.cc
index ead247c428595703cd79e9ae13cb880c13c66458..41618b5a937b98437db74f34c0c15cbe64bca35e 100644
--- a/content/browser/debugger/devtools_manager_unittest.cc
+++ b/content/browser/debugger/devtools_manager_unittest.cc
@@ -217,7 +217,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
// Navigate to URL. First URL should use first RenderViewHost.
const GURL url("http://www.google.com");
controller().LoadURL(
- url, GURL(), content::PAGE_TRANSITION_TYPED, std::string());
+ url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
ViewHostMsg_FrameNavigate_Params params1;
InitNavigateParams(&params1, 1, url, content::PAGE_TRANSITION_TYPED);
TestRenderViewHost* orig_rvh = rvh();
@@ -233,14 +233,14 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
// Navigate to new site which should get a new RenderViewHost.
const GURL url2("http://www.yahoo.com");
controller().LoadURL(
- url2, GURL(), content::PAGE_TRANSITION_TYPED, std::string());
+ url2, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
EXPECT_TRUE(contents()->cross_navigation_pending());
EXPECT_EQ(&client_host, devtools_manager->GetDevToolsClientHostFor(
DevToolsAgentHostRegistry::GetDevToolsAgentHost(pending_rvh())));
// Interrupt pending navigation and navigate back to the original site.
controller().LoadURL(
- url, GURL(), content::PAGE_TRANSITION_TYPED, std::string());
+ url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
contents()->TestDidNavigate(orig_rvh, params1);
EXPECT_FALSE(contents()->cross_navigation_pending());
EXPECT_EQ(&client_host, devtools_manager->GetDevToolsClientHostFor(
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | content/browser/renderer_host/render_view_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698