Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 8785002: Updated SDK scons files to handle new gyp file format in ppapi (Closed)

Created:
9 years ago by mball
Modified:
9 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Updated SDK scons files to handle new gyp file format in ppapi Tested by comparing output of ./scons -n extra_sdk_update_header both before and after. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M native_client_sdk/src/build_tools/build.scons View 3 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Matt Ball
This should fix the SDK build bots. This regression was introduced in r112495. Until we ...
9 years ago (2011-12-02 21:59:18 UTC) #1
bradn
LGTM thanks Matt!
9 years ago (2011-12-02 22:01:26 UTC) #2
Matt Ball
Looks like I invited the google address instead of chromium. Could I get another approval...? ...
9 years ago (2011-12-02 22:32:16 UTC) #3
bradn
lgtm
9 years ago (2011-12-02 22:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mball@chromium.org/8785002/1
9 years ago (2011-12-02 22:41:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 8785002-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-02 22:41:05 UTC) #6
Matt Ball
Hi Brad, Okay -- Looks like that last approval didn't quite do it. Sorry to ...
9 years ago (2011-12-02 22:45:06 UTC) #7
bradnelson
lgtm
9 years ago (2011-12-02 22:50:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mball@chromium.org/8785002/1
9 years ago (2011-12-02 22:51:17 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-03 00:49:32 UTC) #10
Change committed as 112832

Powered by Google App Engine
This is Rietveld 408576698