Issue 8784012: Cleanup: Rename PrintMsg_Print_Params struct member variable (printable_size => content_size).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8784012: Cleanup: Rename PrintMsg_Print_Params struct member variable (printable_size => content_size). (Closed)

Created:
9 years ago by kmadhusu

Modified:
9 years ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PrintPreview: Rename PrintMsg_Print_Params struct member variable (printable_size => content_size). |printable_size| is a misnomer. |content_size| is correct. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112945

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -26 lines)			Patch
M	chrome/browser/printing/print_dialog_cloud.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/printing_message_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/print_messages.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/print_messages.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/mock_printer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/mock_printer.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8784012/1

9 years ago (2011-12-04 21:23:03 UTC) #3

Change committed as 112945

Expand Messages | Collapse Messages