Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_tab_container_win.cc
diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc
index c595519878ec2ac134a12931fd9265b40c91f675..137f464c33bf9d1a636b7b11affdaec25045dd84 100644
--- a/chrome/browser/external_tab_container_win.cc
+++ b/chrome/browser/external_tab_container_win.cc
@@ -51,6 +51,9 @@
#include "content/public/common/page_zoom.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCtring.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebReferrerPolicy.h"
Avi (use Gerrit) 2011/12/05 02:33:48 This change; are we allowing access to WebKit from
jam 2011/12/05 03:23:01 we do allow WebKit types (from our WebKit API). Yo
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/menu_model.h"
#include "ui/base/resource/resource_bundle.h"
@@ -59,6 +62,9 @@
using content::BrowserThread;
using ui::ViewProp;
+using WebKit::WebCString;
+using WebKit::WebString;
+using WebKit::WebReferrerPolicy;
static const char kWindowObjectKey[] = "ChromeWindowObject";
@@ -347,18 +353,21 @@ TabContents* ExternalTabContainer::OpenURLFromTab(TabContents* source,
case NEW_WINDOW:
case SAVE_TO_DISK:
if (automation_) {
+ GURL referrer = GURL(WebSecurityPolicy::generateReferrerHeader(
+ params.referrer.policy,
+ params.url,
+ WebString::fromUTF8(params.referrer.url.spec())).utf8());
automation_->Send(new AutomationMsg_OpenURL(tab_handle_,
params.url,
- params.referrer,
+ referrer,
params.disposition));
// TODO(ananta)
// We should populate other fields in the
// ViewHostMsg_FrameNavigate_Params structure. Another option could be
// to refactor the UpdateHistoryForNavigation function in TabContents.
content::FrameNavigateParams nav_params;
- nav_params.referrer = content::Referrer(
- params.referrer,
- WebKit::WebReferrerPolicyDefault);
+ nav_params.referrer = content::Referrer(referrer,
+ params.referrer.policy);
nav_params.url = params.url;
nav_params.page_id = -1;
nav_params.transition = content::PAGE_TRANSITION_LINK;

Powered by Google App Engine
This is Rietveld 408576698