chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc - Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/automation_provider_win.cc ('K') | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/bookmarks/bookmark_utils.cc » ('j') | chrome/browser/external_tab_container_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc

diff --git a/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc

index f5705ba715523e6b7a117e9791a7ff0cb652cda8..538de7cdc4e7843b2ab8e4d00f240a5cd416906e 100644

--- a/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc

+++ b/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc

@@ -33,8 +33,9 @@ class TestingPageNavigator : public PageNavigator {

const GURL& referrer,

WindowOpenDisposition disposition,

content::PageTransition transition) OVERRIDE {

- return OpenURL(OpenURLParams(url, referrer, disposition, transition,

- false));

+ DCHECK(referrer.is_empty());

+ return OpenURL(OpenURLParams(url, content::Referrer(), disposition,

+ transition, false));

}

virtual TabContents* OpenURL(const OpenURLParams& params) OVERRIDE {