chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc - Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/external_tab_container_win.cc ('K') | « chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc ('k') | content/browser/tab_contents/page_navigator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

diff --git a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

index 1c8a92e8fc93227527de527eb14c66b8e2f1a244..b6360243f9fe51f815593b20d8de23d86767d5c2 100644

--- a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

+++ b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

@@ -72,7 +72,7 @@ TEST_F(HtmlDialogTabContentsDelegateTest, DoNothingMethodsTest) {

TEST_F(HtmlDialogTabContentsDelegateTest, OpenURLFromTabTest) {

test_tab_contents_delegate_->OpenURLFromTab(

- NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), GURL(),

+ NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), content::Referrer(),

NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));

// This should create a new foreground tab in the existing browser.

EXPECT_EQ(1, browser()->tab_count());

@@ -95,7 +95,7 @@ TEST_F(HtmlDialogTabContentsDelegateTest, DetachTest) {

EXPECT_EQ(NULL, test_tab_contents_delegate_->profile());

// Now, none of the following calls should do anything.

test_tab_contents_delegate_->OpenURLFromTab(

- NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), GURL(),

+ NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), content::Referrer(),

NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));

test_tab_contents_delegate_->AddNewContents(NULL, NULL, NEW_FOREGROUND_TAB,

gfx::Rect(), false);