Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5193)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8784006: Replace the GURL referrer field of OpenURLParams with a content::Referrer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 5aadcc827c32f6bb69e0ef0d047524a78a3a13b1..f5a012da8efdf9bb1960c1bbab7cb30078d4473b 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -769,8 +769,11 @@ TabContents* Browser::OpenApplicationTab(Profile* profile,
TabStripModel* model = browser->tabstrip_model();
int tab_index = model->GetWrapperIndex(existing_tab);
- existing_tab->OpenURL(OpenURLParams(extension_url, existing_tab->GetURL(),
- disposition, content::PAGE_TRANSITION_LINK, false));
+ existing_tab->OpenURL(OpenURLParams(
+ extension_url,
+ content::Referrer(existing_tab->GetURL(),
+ WebKit::WebReferrerPolicyDefault),
+ disposition, content::PAGE_TRANSITION_LINK, false));
if (params.tabstrip_add_types & TabStripModel::ADD_PINNED) {
model->SetTabPinned(tab_index, true);
tab_index = model->GetWrapperIndex(existing_tab);
@@ -2969,9 +2972,8 @@ TabContents* Browser::OpenURL(const GURL& url,
content::PageTransition transition) {
// For specifying a referrer, use the version of OpenURL taking OpenURLParams.
DCHECK(referrer.is_empty());
- return OpenURLFromTab(NULL,
- OpenURLParams(url, referrer, disposition, transition,
- false));
+ return OpenURLFromTab(NULL, OpenURLParams(
+ url, content::Referrer(), disposition, transition, false));
}
TabContents* Browser::OpenURL(const OpenURLParams& params) {
@@ -3386,7 +3388,7 @@ TabContents* Browser::OpenURLFromTab(TabContents* source,
nav_params.source_contents =
tabstrip_model()->GetTabContentsAt(
tabstrip_model()->GetWrapperIndex(source));
- nav_params.referrer = params.referrer;
+ nav_params.referrer = params.referrer.url;
nav_params.disposition = params.disposition;
nav_params.tabstrip_add_types = TabStripModel::ADD_NONE;
nav_params.window_action = browser::NavigateParams::SHOW_WINDOW;

Powered by Google App Engine
This is Rietveld 408576698