Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8784004: Update includes to new header locations. (Closed)

Created:
9 years ago by abarth-chromium
Modified:
9 years ago
CC:
chromium-reviews, jstritar+watch_chromium.org, GeorgeY, dhollowa+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, dyu1, Paweł Hajdan Jr., Ilya Sherman
Visibility:
Public.

Description

Update includes to new header locations. TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112826

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M chrome/browser/browsing_data_database_helper.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/browsing_data_local_storage_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/web_apps.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/password_autofill_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/file_browser_private_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/frame_sniffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_click_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_click_tracker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/blocked_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/missing_plugin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/missing_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_thumbnailer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_thumbnailer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
9 years ago (2011-12-02 22:53:45 UTC) #1
darin (slow to review)
9 years ago (2011-12-02 23:17:52 UTC) #2 
LGTM

http://codereview.chromium.org/8784004/diff/1/chrome/browser/browsing_data_da...
File chrome/browser/browsing_data_database_helper.cc (right):

http://codereview.chromium.org/8784004/diff/1/chrome/browser/browsing_data_da...
chrome/browser/browsing_data_database_helper.cc:16: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebSecurityOrigin.h"
need to fix sorting? :-(

Powered by Google App Engine
This is Rietveld 408576698