Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 8784003: base::Bind: Convert SSLHostInfo::WaitForDataReady. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert SSLHostInfo::WaitForDataReady. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112899

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -55 lines) Patch
M net/http/disk_cache_based_ssl_host_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info.cc View 1 5 chunks +13 lines, -12 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info_unittest.cc View 9 chunks +13 lines, -24 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M net/socket/ssl_host_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_host_info.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years ago (2011-12-02 22:30:08 UTC) #1
csilv
lgtm
9 years ago (2011-12-02 22:50:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/8784003/3002
9 years ago (2011-12-03 18:21:57 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-03 18:22:01 UTC) #4
Presubmit check for 8784003-3002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
net/http/disk_cache_based_ssl_host_info.cc,net/socket/ssl_client_socket_nss.h,net/http/disk_cache_based_ssl_host_info_unittest.cc,net/socket/ssl_client_socket_nss.cc,net/http/disk_cache_based_ssl_host_info.h,net/socket/ssl_host_info.h,net/socket/ssl_host_info.cc

Presubmit checks took 1.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698