Refactored HostList to better support bookmarking.

remoting/webapp/me2mom/client_screen.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'client screen' for Chromoting.
  */
 
 'use strict';
@@ skipping 18 matching lines @@
  * @type {string} The normalized access code.
  */
 remoting.accessCode = '';
 
 /**
  * @type {string} The host's JID, returned by the server.
  */
 remoting.hostJid = '';
 
 /**
+ * @type {string} For Me2Me connections, the id of the current host, used when
+ *     (re-)connecting, as the JID may have changed.
+ */
+remoting.hostId = '';
+
+/**
  * @type {string} The host's public key, returned by the server.
  */
 remoting.hostPublicKey = '';
 
 /**
  * @type {XMLHttpRequest} The XHR object corresponding to the current
  *     support-hosts request, if there is one outstanding.
  */
 remoting.supportHostsXhr_ = null;
 
@@ skipping 192 matching lines @@
       // only with older client plugins. Current version should go the
       // FAILED state when connection fails.
       showConnectError_(remoting.Error.INVALID_ACCESS_CODE);
     }
 
   } else if (newState == remoting.ClientSession.State.CONNECTION_FAILED) {
     remoting.debug.log('Client plugin reported connection failed: ' +
                        remoting.clientSession.error);
     if (remoting.clientSession.error ==
         remoting.ClientSession.ConnectionError.HOST_IS_OFFLINE) {
-      showConnectError_(remoting.Error.HOST_IS_OFFLINE);
+      retryConnectOrReportOffline_();
     } else if (remoting.clientSession.error ==
                remoting.ClientSession.ConnectionError.SESSION_REJECTED) {
       showConnectError_(remoting.Error.INVALID_ACCESS_CODE);
     } else if (remoting.clientSession.error ==
                remoting.ClientSession.ConnectionError.INCOMPATIBLE_PROTOCOL) {
       showConnectError_(remoting.Error.INCOMPATIBLE_PROTOCOL);
     } else if (remoting.clientSession.error ==
                remoting.ClientSession.ConnectionError.NETWORK_FAILURE) {
       showConnectError_(remoting.Error.GENERIC);
     } else {
       showConnectError_(remoting.Error.GENERIC);
     }
 
   } else {
     remoting.debug.log('Unexpected client plugin state: ' + newState);
     // This should only happen if the web-app and client plugin get out of
     // sync, and even then the version check should allow compatibility.
     showConnectError_(remoting.Error.MISSING_PLUGIN);
   }
 }
 
 /**
+ * If we have a hostId to retry, try refreshing it and connecting again. If not,
+ * then show the 'host offline' error message.
+ *
+ * @return {void} Nothing.
+ */
+function retryConnectOrReportOffline_() {
+  if (remoting.hostId) {
+    console.log('Connection failed. Retrying.');
+    /** @param {boolean} success True if the refresh was successful. */
+    var onDone = function(success) {
+      if (success) {
+        remoting.connectHost(remoting.hostId, false);
+      } else {
+        showConnectError_(remoting.Error.HOST_IS_OFFLINE);
+      }
+    };
+    remoting.hostList.refresh(onDone);
+  } else {
+    console.log('Connection failed. Not retrying.');
+    showConnectError_(remoting.Error.HOST_IS_OFFLINE);
+  }
+}
+
+/**
  * Create the client session object and initiate the connection.
  *
  * @return {void} Nothing.
  */
 function startSession_() {
   remoting.debug.log('Starting session...');
   var accessCode = document.getElementById('access-code-entry');
   accessCode.value = '';  // The code has been validated and won't work again.
   remoting.clientSession =
       new remoting.ClientSession(
@@ skipping 105 matching lines @@
   }
   var stats = remoting.clientSession.stats();
   remoting.debug.updateStatistics(stats);
   remoting.clientSession.logStatistics(stats);
   // Update the stats once per second.
   window.setTimeout(updateStatistics_, 1000);
 }
 
 
 /**
- * Start a connection to the specified host, using the stored details.
+ * Start a connection to the specified host, using the cached details.
  *
- * @param {string} hostJid The jabber Id of the host.
- * @param {string} hostPublicKey The public key of the host.
- * @param {string} hostName The name of the host.
+ * @param {string} hostId The unique id of the host.
+ * @param {boolean} retryIfOffline If true and the host can't be contacted,
+ *     refresh the host list and try again. This allows bookmarked hosts to
+ *     work even if they reregister with Talk and get a different Jid.
  * @return {void} Nothing.
  */
-remoting.connectHost = function(hostJid, hostPublicKey, hostName) {
-  // TODO(jamiewalch): Instead of passing the jid in the URL, cache it in local
-  // storage so that host bookmarks can be implemented efficiently.
-  remoting.hostJid = hostJid;
-  remoting.hostPublicKey = hostPublicKey;
-  document.getElementById('connected-to').innerText = hostName;
-  document.title = document.title + ': ' + hostName;
-
+remoting.connectHost = function(hostId, retryIfOffline) {
   remoting.debug.log('Connecting to host...');
   remoting.currentConnectionType = remoting.ConnectionType.Me2Me;
+
+  // Storing the hostId indicates that it should be retried on failure.
+  remoting.hostId = retryIfOffline ? hostId : '';
   remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
 
+  var host = remoting.hostList.getHostForId(hostId);
+  if (!host) {
+    retryConnectOrReportOffline_();
+    return;
+  }
+  remoting.hostJid = host.jabberId;
+  remoting.hostPublicKey = host.publicKey;
+  document.getElementById('connected-to').innerText = host.hostName;
+  document.title = document.title + ': ' + host.hostName;
+
   if (!remoting.wcsLoader) {
     remoting.wcsLoader = new remoting.WcsLoader();
   }
   /** @param {function(string):void} setToken The callback function. */
   var callWithToken = function(setToken) {
     remoting.oauth2.callWithToken(setToken);
   };
   remoting.wcsLoader.startAsync(callWithToken, remoting.connectHostWithWcs);
 }
 
 /**
  * Continue making the connection to a host, once WCS has initialized.
  *
  * @return {void} Nothing.
  */
 remoting.connectHostWithWcs = function() {
   remoting.clientSession =
-  new remoting.ClientSession(
-      remoting.hostJid, remoting.hostPublicKey,
-      '', /** @type {string} */ (remoting.oauth2.getCachedEmail()),
-      onClientStateChange_);
+      new remoting.ClientSession(
+          remoting.hostJid, remoting.hostPublicKey,
+          '', /** @type {string} */ (remoting.oauth2.getCachedEmail()),
+          onClientStateChange_);
   /** @param {string} token The auth token. */
   var createPluginAndConnect = function(token) {
     remoting.clientSession.createPluginAndConnect(
         document.getElementById('session-mode'),
         token);
   };
 
   remoting.oauth2.callWithToken(createPluginAndConnect);
 }
 
 }());