Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 8781001: GTK: Port omnibox drawing from GdkGC interface to cairo. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
9 years ago
Reviewers:
Nico, Evan Stade
CC:
chromium-reviews, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Port omnibox drawing from GdkGC interface to cairo. (Now with a fix for the crash from Friday; we need to copy the bitmap into a different format first for ownership reasons.) GdkGC is deprecated and will be removed in gtk3 and cairo should be faster anyway. This uses the new CairoCachedSurface in gfx::Image. BUG=79722 TEST=none First commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=112839 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113033

Patch Set 1 #

Patch Set 2 : TODO for theme service #

Patch Set 3 : And remove whitespace #

Total comments: 1

Patch Set 4 : remove stray line found by estade #

Patch Set 5 : Fix crash by copying bitmap. #

Total comments: 1

Patch Set 6 : Added comment for thakis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -45 lines) Patch
M chrome/browser/themes/theme_service.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 2 3 4 5 9 chunks +50 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Elliot Glaysher
9 years ago (2011-12-02 21:24:35 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/8781001/diff/10/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (right): http://codereview.chromium.org/8781001/diff/10/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc#newcode635 chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:635: ?
9 years ago (2011-12-02 21:55:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8781001/2002
9 years ago (2011-12-02 22:00:35 UTC) #3
commit-bot: I haz the power
Try job failure for 8781001-2002 (retry) on linux_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-02 23:13:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8781001/2002
9 years ago (2011-12-02 23:19:37 UTC) #5
commit-bot: I haz the power
Change committed as 112839
9 years ago (2011-12-03 01:27:53 UTC) #6
Elliot Glaysher
thakis: fix for the crash I introduced (and you reverted) on Friday. can I get ...
9 years ago (2011-12-05 18:53:43 UTC) #7
Nico
lgtm stamp http://codereview.chromium.org/8781001/diff/11001/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (right): http://codereview.chromium.org/8781001/diff/11001/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc#newcode493 chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:493: images_[bitmap] = new gfx::Image(gfx::GdkPixbufFromSkBitmap(bitmap)); Can you explain ...
9 years ago (2011-12-05 18:55:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8781001/17002
9 years ago (2011-12-05 19:07:02 UTC) #9
Elliot Glaysher
On 2011/12/05 18:55:39, Nico wrote: > http://codereview.chromium.org/8781001/diff/11001/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc#newcode493 > chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:493: images_[bitmap] = > new gfx::Image(gfx::GdkPixbufFromSkBitmap(bitmap)); > ...
9 years ago (2011-12-05 19:08:54 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-05 21:31:45 UTC) #11
Change committed as 113033

Powered by Google App Engine
This is Rietveld 408576698