Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: ui/views/widget/tooltip_manager_aura.cc

Issue 8780001: aura: Make aura::TooltipClient completely static? (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged with upstream Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/aura/aura.gyp ('K') | « ui/views/views.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/tooltip_manager_aura.cc
diff --git a/ui/views/widget/tooltip_manager_aura.cc b/ui/views/widget/tooltip_manager_aura.cc
index 0847ed3fa6b2f1feab811ae0cec2a09b3ba81288..716ce4a47a478e698add0a150b110957c42b297e 100644
--- a/ui/views/widget/tooltip_manager_aura.cc
+++ b/ui/views/widget/tooltip_manager_aura.cc
@@ -50,45 +50,35 @@ TooltipManagerAura::~TooltipManagerAura() {
// TooltipManagerAura, TooltipManager implementation:
void TooltipManagerAura::UpdateTooltip() {
- void* property = aura::Desktop::GetInstance()->GetProperty(
- aura::kDesktopTooltipClientKey);
- if (property) {
- gfx::Point view_point = aura::Desktop::GetInstance()->last_mouse_location();
- aura::Window::ConvertPointToWindow(aura::Desktop::GetInstance(),
- native_widget_aura_->GetNativeView(), &view_point);
- View* view = GetViewUnderPoint(view_point);
- if (view) {
- View::ConvertPointFromWidget(view, &view_point);
- if (!view->GetTooltipText(view_point, &tooltip_text_))
- tooltip_text_.clear();
- } else {
- tooltip_text_.clear();
- }
- aura::TooltipClient* tc = static_cast<aura::TooltipClient*>(property);
- tc->UpdateTooltip(native_widget_aura_->GetNativeView());
+ gfx::Point view_point = aura::Desktop::GetInstance()->last_mouse_location();
+ aura::Window::ConvertPointToWindow(aura::Desktop::GetInstance(),
+ native_widget_aura_->GetNativeView(), &view_point);
+ View* view = GetViewUnderPoint(view_point);
+ if (view) {
+ View::ConvertPointFromWidget(view, &view_point);
+ if (!view->GetTooltipText(view_point, &tooltip_text_))
+ tooltip_text_.clear();
+ } else {
+ tooltip_text_.clear();
}
+ aura::TooltipClient::UpdateTooltip(native_widget_aura_->GetNativeView());
}
void TooltipManagerAura::TooltipTextChanged(View* view) {
- void* property = aura::Desktop::GetInstance()->GetProperty(
- aura::kDesktopTooltipClientKey);
- if (property) {
- gfx::Point view_point = aura::Desktop::GetInstance()->last_mouse_location();
- aura::Window::ConvertPointToWindow(aura::Desktop::GetInstance(),
- native_widget_aura_->GetNativeView(), &view_point);
- View* target = GetViewUnderPoint(view_point);
- if (target != view)
- return;
- if (target) {
- View::ConvertPointFromWidget(view, &view_point);
- if (!view->GetTooltipText(view_point, &tooltip_text_))
- tooltip_text_.clear();
- } else {
- tooltip_text_.clear();
- }
- aura::TooltipClient* tc = static_cast<aura::TooltipClient*>(property);
- tc->UpdateTooltip(native_widget_aura_->GetNativeView());
+ gfx::Point view_point = aura::Desktop::GetInstance()->last_mouse_location();
+ aura::Window::ConvertPointToWindow(aura::Desktop::GetInstance(),
+ native_widget_aura_->GetNativeView(), &view_point);
+ View* target = GetViewUnderPoint(view_point);
+ if (target != view)
+ return;
+ if (target) {
+ View::ConvertPointFromWidget(view, &view_point);
+ if (!view->GetTooltipText(view_point, &tooltip_text_))
+ tooltip_text_.clear();
+ } else {
+ tooltip_text_.clear();
}
+ aura::TooltipClient::UpdateTooltip(native_widget_aura_->GetNativeView());
}
void TooltipManagerAura::ShowKeyboardTooltip(View* view) {
« ui/aura/aura.gyp ('K') | « ui/views/views.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698