aura: Make aura::TooltipClient completely static?

aura: Make aura::TooltipClient completely static?

BUG=none
TEST=none

[Ben Goodger (Google), 2011-12-05 22:01:16]

http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp#newcode58
ui/aura/aura.gyp:58: 'target_name': 'non_shell_test_support_aura',
what does non-shell mean?

[varunjain, 2011-12-05 22:11:36]

http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp#newcode58
ui/aura/aura.gyp:58: 'target_name': 'non_shell_test_support_aura',
On 2011/12/05 22:01:16, Ben Goodger (Google) wrote:
> what does non-shell mean?

I know the name is weird.. the intention is that this target provides tests
support for un-defined methods in aura client, but aura_shell_unittests cannot
depend on this because those methods are defined in aura_shell. The sources in
this target should really be in test_support_aura.. but I cannot put it there
because aura_shell_unittests depends on it.

[Ben Goodger (Google), 2011-12-05 22:14:54]

A layer below another layer should never refer to the layer above it.

-Ben

On Mon, Dec 5, 2011 at 2:11 PM, <varunjain@chromium.org> wrote:

>
>
http://codereview.chromium.**org/8780001/diff/6001/ui/aura/**aura.gyp<http://...
> File ui/aura/aura.gyp (right):
>
> http://codereview.chromium.**org/8780001/diff/6001/ui/aura/**
>
aura.gyp#newcode58<http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp#newcode58>
> ui/aura/aura.gyp:58: 'target_name': 'non_shell_test_support_aura',
> On 2011/12/05 22:01:16, Ben Goodger (Google) wrote:
>
>> what does non-shell mean?
>>
>
> I know the name is weird.. the intention is that this target provides
> tests support for un-defined methods in aura client, but
> aura_shell_unittests cannot depend on this because those methods are
> defined in aura_shell. The sources in this target should really be in
> test_support_aura.. but I cannot put it there because
> aura_shell_unittests depends on it.
>
>
http://codereview.chromium.**org/8780001/<http://codereview.chromium.org/8780...
>

[varunjain, 2011-12-05 22:43:51]

On 2011/12/05 22:14:54, Ben Goodger (Google) wrote:
> A layer below another layer should never refer to the layer above it.

Its not really a reference.. I just wanted the name to be indicative. Perhaps
"static_test_support_aura" is better because this target mostly provides tests
support for static/global methods declared in aura. So if its just the name, I'd
be happy to change it.

If you dont think that this should be a separate target, then I am open to
suggestions. My use case is as follows:

Need to provide test support for static functions declared in
aura::TooltipManager, defined in aura_shell::ShellTooltipManager to
views_unittests and content_unittests.
I tried putting the test definitions in ui/base/tests and expose them using
ui/ui.gyp:ui_test_support. But that does not work because chrome.gyp:unit_tests
depend on both ui_test_suport and aura_shell so the definitions conflict.

> 
> -Ben
> 
> On Mon, Dec 5, 2011 at 2:11 PM, <mailto:varunjain@chromium.org> wrote:
> 
> >
> >
>
http://codereview.chromium.**org/8780001/diff/6001/ui/aura/**aura.gyp%3Chttp:...>
> > File ui/aura/aura.gyp (right):
> >
> > http://codereview.chromium.**org/8780001/diff/6001/ui/aura/**
> >
>
aura.gyp#newcode58<http://codereview.chromium.org/8780001/diff/6001/ui/aura/aura.gyp#newcode58>
> > ui/aura/aura.gyp:58: 'target_name': 'non_shell_test_support_aura',
> > On 2011/12/05 22:01:16, Ben Goodger (Google) wrote:
> >
> >> what does non-shell mean?
> >>
> >
> > I know the name is weird.. the intention is that this target provides
> > tests support for un-defined methods in aura client, but
> > aura_shell_unittests cannot depend on this because those methods are
> > defined in aura_shell. The sources in this target should really be in
> > test_support_aura.. but I cannot put it there because
> > aura_shell_unittests depends on it.
> >
> >
>
http://codereview.chromium.**org/8780001/%3Chttp://codereview.chromium.org/87...>
> >