Re-enable basic JS unittests for Chromoting.

Re-enable basic JS unittests for Chromoting.
This doesn't suffer from the ninja build problems that the first version had.

BUG=none
TEST=ninja chrome; make chrome; make remoting_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161401

[garykac, 2011-12-14 23:59:45]

+bradnelson, mark because this seems kinda ugly and I'm hoping there's a better
way to do this.

Summary:

remoting_unittests needs to depend on common_constants.

I'd like to simply depend on chrome.gyp:common_constants, but the Mac circular
checks fail if I do that.

Having all builds include the .gypi directly causes linux ninja builds to fail
(multiply-defined target).

[Mark Mentovai, 2011-12-19 16:13:37]

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp#newcode34
remoting/remoting.gyp:34: 'version_py_path': '<(version_py_path)',
I don’t think version_py_path and version_path are needed in this scope, unless
they’re needed by some included file.

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp#newcod...
remoting/remoting.gyp:915:
'<(DEPTH)/chrome/test/base/run_all_remoting_unittests.cc',
Can you just write the right number of dots here instead of using <(DEPTH)?

[garykac, 2012-01-04 21:04:44]

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp#newcode34
remoting/remoting.gyp:34: 'version_py_path': '<(version_py_path)',
On 2011/12/19 16:13:37, Mark Mentovai wrote:
> I don’t think version_py_path and version_path are needed in this scope,
unless
> they’re needed by some included file.

They're needed by common_constants.gypi (included below).

http://codereview.chromium.org/8779002/diff/9001/remoting/remoting.gyp#newcod...
remoting/remoting.gyp:915:
'<(DEPTH)/chrome/test/base/run_all_remoting_unittests.cc',
On 2011/12/19 16:13:37, Mark Mentovai wrote:
> Can you just write the right number of dots here instead of using <(DEPTH)?

Yes.

But the <(DEPTH) option was added to avoid hard-coding directory depth and seems
like the better choice.

[garykac, 2012-10-11 15:31:41]

+sky for chrome/tests

ptal. This has been simplified now that common_constants has been moved into a
proper .gyp file.

[Mark Mentovai, 2012-10-11 15:45:50]

gyp LGTM

[sky, 2012-10-11 17:30:57]

LGTM

[commit-bot: I haz the power, 2012-10-11 18:41:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/8779002/26002

[commit-bot: I haz the power, 2012-10-11 19:02:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-11 19:39:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/8779002/26002

[commit-bot: I haz the power, 2012-10-11 21:13:22]

Change committed as 161401