Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8776049: Do not show percentages when we don't know what they are in test progress indication. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 2f9a3212d64acb6c7b85d9d879394c03473a6b10..297e46c1bd79d41f7d587b3cde33a971423fd7a9 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -326,12 +326,12 @@ class ProcessQueue {
void _checkDone() {
// When there are no more active test listers ask for more work
// from process queue users.
- if (_activeTestListers == 0 &&
- !_enqueueMoreWork(this) &&
- _tests.isEmpty() &&
- _numProcesses == 0) {
- _terminateDartcBatchRunners();
- _progress.allDone();
+ if (_activeTestListers == 0 && !_enqueueMoreWork(this)) {
+ _progress.allTestsKnown();
+ if (_tests.isEmpty() && _numProcesses == 0) {
+ _terminateDartcBatchRunners();
+ _progress.allDone();
+ }
}
}
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698