Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: tools/testing/dart/test_options.dart

Issue 8776049: Do not show percentages when we don't know what they are in test progress indication. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 097a6706fd65350773a17cd088f2c16449a84595..5b7acdf5e392a1887b7e3d7bcc97895b94756aa6 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -49,8 +49,7 @@ class TestOptionsParser {
'component',
'The component to test against',
['-c', '--component'],
- ['most', 'vm', 'dartc', 'frog', 'frogsh', 'leg',
- 'chromium', 'dartium', 'frogium', 'webdriver'],
+ ['most', 'vm', 'dartc', 'frog', 'frogsh', 'leg'],
'vm'),
new _TestOptionSpecification(
'architecture',
@@ -172,13 +171,13 @@ class TestOptionsParser {
var spec = _getSpecification(name);
if (spec == null) {
print('Unknown test option $name');
- return null;
+ exit(1);
}
// Parse the value for the option.
if (spec.type == 'bool') {
if (!value.isEmpty()) {
print('No value expected for bool option $name');
- return null;
+ exit(1);
}
configuration[spec.name] = true;
} else if (spec.type == 'int') {
@@ -186,14 +185,14 @@ class TestOptionsParser {
configuration[spec.name] = Math.parseInt(value);
} catch (var e) {
print('Integer value expected for int option $name');
- return null;
+ exit(1);
}
} else {
assert(spec.type == 'string');
for (var v in value.split(',')) {
if (spec.values.lastIndexOf(v) == -1) {
print('Unknown value ($v) for option $name');
- return null;
+ exit(1);
}
}
configuration[spec.name] = value;
« no previous file with comments | « no previous file | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698