Do not show percentages when we don't know what they are in test progress indication.

tools/testing/dart/test_progress.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_progress");
 
 #import("test_runner.dart");
 #import("test_suite.dart");
 
 class ProgressIndicator {
@@ skipping 28 matching lines @@
   void done(TestCase test) {
     if (test.output.unexpectedOutput) {
       _failedTests++;
       _printFailureOutput(test);
     } else {
       _passedTests++;
     }
     _printDoneProgress(test);
   }
 
+  void allTestsKnown() {
+    if (!_allTestsKnown) SummaryReport.printReport();
+    _allTestsKnown = true;
+  }
+
   abstract allDone();
   abstract _printStartProgress();
   abstract _printDoneProgress();
 
   String _pad(String s, int length) {
     StringBuffer buffer = new StringBuffer();
     for (int i = s.length; i < length; i++) {
       buffer.add(' ');
     }
     buffer.add(s);
@@ skipping 48 matching lines @@
       print('=== ${_failedTests} test$pluralSuffix failed');
       print('===\n');
     }
   }
 
   int _completedTests() => _passedTests + _failedTests;
 
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
+  bool _allTestsKnown = false;
   Date _startTime;
 }
 
 
-class CompactProgressIndicator extends ProgressIndicator {
-  CompactProgressIndicator(Date startTime) : super(startTime);
+class CompactIndicator extends ProgressIndicator {
+  CompactIndicator(Date startTime) : super(startTime);
 
   void allDone() {
-    SummaryReport.printReport();
     stdout.write('\n'.charCodes());
     stdout.close();
-  }
-
-  void _printProgress() {
-    var percent = ((_completedTests() / _foundTests) * 100).floor().toString();
-    var percentPadded = _pad(percent, 5);
-    var passedPadded = _pad(_passedTests.toString(), 5);
-    var failedPadded = _pad(_failedTests.toString(), 5);
-    var progressLine =
-        '\r[${_timeString()} | $percentPadded% | ' +
-        '+$passedPadded | -$failedPadded]';
-    stdout.write(progressLine.charCodes());
+    exit(_failedTests > 0 ? 1 : 0);
   }
 
   void _printStartProgress(TestCase test) => _printProgress();
   void _printDoneProgress(TestCase test) => _printProgress();
+
+  String _nextSpinner() {
+    _spinnerIndex = (_spinnerIndex + 1) % 4;
+    return _spinners[_spinnerIndex];
+  }
+
+  static int _spinnerIndex = 0;
+  static List<String> _spinners = const ['- ', '\\ ', '| ', '/ '];
 }
 
 
-class ColorProgressIndicator extends ProgressIndicator {
+class CompactProgressIndicator extends CompactIndicator {
+  CompactProgressIndicator(Date startTime) : super(startTime);
+
+  void _printProgress() {
+    var percent = ((_completedTests() / _foundTests) * 100).floor().toString();
+    var progressPadded = _pad(_allTestsKnown ? percent : _nextSpinner(), 5);
+    var passedPadded = _pad(_passedTests.toString(), 5);
+    var failedPadded = _pad(_failedTests.toString(), 5);
+    var progressLine =
+        '\r[${_timeString()} | $progressPadded% | ' +
+        '+$passedPadded | -$failedPadded]';
+    stdout.write(progressLine.charCodes());
+  }
+}
+
+
+class ColorProgressIndicator extends CompactIndicator {
   ColorProgressIndicator(Date startTime) : super(startTime);
 
-  void allDone() {
-    SummaryReport.printReport();
-    stdout.write('\n'.charCodes());
-    stdout.close();
-  }
-
   static int GREEN = 32;
   static int RED = 31;
   static int NONE = 0;
 
   addColorWrapped(List<int> codes, String string, int color) {
     codes.add(27);
     codes.addAll('[${color}m'.charCodes());
     codes.addAll(string.charCodes());
     codes.add(27);
     codes.addAll('[0m'.charCodes());
   }
 
   void _printProgress() {
     var percent = ((_completedTests() / _foundTests) * 100).floor().toString();
-    var percentPadded = _pad(percent, 5);
+    var progressPadded = _pad(_allTestsKnown ? percent : _nextSpinner(), 5);
     var passedPadded = _pad(_passedTests.toString(), 5);
     var failedPadded = _pad(_failedTests.toString(), 5);
     var progressLine = [];
-    progressLine.addAll('\r[${_timeString()} | $percentPadded% | '.charCodes());
+    progressLine.addAll('\r[${_timeString()} | $progressPadded% | '.charCodes());
     addColorWrapped(progressLine, '+$passedPadded ', GREEN);
     progressLine.addAll('| '.charCodes());
     var failedColor = (_failedTests != 0) ? RED : NONE;
     addColorWrapped(progressLine, '-$failedPadded', failedColor);
     progressLine.addAll(']'.charCodes());
     stdout.write(progressLine);
   }
-
-  void _printStartProgress(TestCase test) => _printProgress();
-  void _printDoneProgress(TestCase test) => _printProgress();
 }
 
 
-
 class LineProgressIndicator extends ProgressIndicator {
   LineProgressIndicator(Date startTime) : super(startTime);
 
   void allDone() {
     _printStatus();
-    SummaryReport.printReport();
+    exit(_failedTests > 0 ? 1 : 0);
   }
 
   void _printStartProgress(TestCase test) {
   }
 
   void _printDoneProgress(TestCase test) {
     var status = 'pass';
     if (test.output.unexpectedOutput) {
       status = 'fail';
     }
     print('Done ${test.displayName}: $status');
   }
 }
 
 
 class VerboseProgressIndicator extends ProgressIndicator {
   VerboseProgressIndicator(Date startTime) : super(startTime);
 
   void allDone() {
     _printStatus();
-    SummaryReport.printReport();
+    exit(_failedTests > 0 ? 1 : 0);
   }
 
   void _printStartProgress(TestCase test) {
     print('Starting ${test.displayName}...');
   }
 
   void _printDoneProgress(TestCase test) {
     var status = 'pass';
     if (test.output.unexpectedOutput) {
       status = 'fail';
     }
     print('Done ${test.displayName}: $status');
   }
 }
 
 
 class StatusProgressIndicator extends ProgressIndicator {
   StatusProgressIndicator(Date startTime) : super(startTime);
 
   void allDone() {
     _printStatus();
-    SummaryReport.printReport();
+    exit(_failedTests > 0 ? 1 : 0);
   }
 
   void _printStartProgress(TestCase test) {
   }
 
   void _printDoneProgress(TestCase test) {
   }
 }
 
 
 class BuildbotProgressIndicator extends ProgressIndicator {
   BuildbotProgressIndicator(Date startTime) : super(startTime);
 
   void allDone() {
     _printStatus();
+    exit(_failedTests > 0 ? 1 : 0);
   }
 
   void _printStartProgress(TestCase test) {
   }
 
   void _printDoneProgress(TestCase test) {
     var status = 'pass';
     if (test.output.unexpectedOutput) {
       status = 'fail';
     }
     var percent = ((_completedTests() / _foundTests) * 100).toInt().toString();
     print('Done ${test.displayName}: $status');
     print('@@@STEP_CLEAR@@@');
     print('@@@STEP_TEXT@ $percent% +$_passedTests -$_failedTests @@@');
   }
 }