Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8776037: aura-shell: Export to fix component build of aura_shell_unittests. (Closed)

Created:
9 years ago by sadrul
Modified:
9 years ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura-shell: Export to fix component build of aura_shell_unittests. BUG=none TEST=aura_shell_unittests compiles with component=shared_library Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/aura_shell/window_util.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
9 years ago (2011-12-02 02:30:54 UTC) #1
Ben Goodger (Google)
9 years ago (2011-12-02 04:11:19 UTC) #2
LGTM

On Thu, Dec 1, 2011 at 6:30 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> aura-shell: Export to fix component build of aura_shell_unittests.
>
> BUG=none
> TEST=aura_shell_unittests compiles with component=shared_library
>
>
> Please review this at
http://codereview.chromium.**org/8776037/<http://codereview.chromium.org/8776...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/aura_shell/window_util.h
>
>
> Index: ui/aura_shell/window_util.h
> diff --git a/ui/aura_shell/window_util.h b/ui/aura_shell/window_util.h
> index 7e2203be37263a733c941fdbb60d9b**51bcd46561..**
> 1550510253c0663ff5c6dc1813559b**fcccc0dfa0 100644
> --- a/ui/aura_shell/window_util.h
> +++ b/ui/aura_shell/window_util.h
> @@ -6,6 +6,8 @@
>  #define UI_AURA_SHELL_WINDOW_UTIL_H_
>  #pragma once
>
> +#include "ui/aura_shell/aura_shell_**export.h"
> +
>  namespace aura {
>  class Window;
>  }
> @@ -13,7 +15,7 @@ class Window;
>  namespace aura_shell {
>
>  // Returns true if |window| is in the maximized state.
> -bool IsWindowMaximized(aura::**Window* window);
> +AURA_SHELL_EXPORT bool IsWindowMaximized(aura::**Window* window);
>
>  }  // namespace aura_shell
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698