Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.cc

Issue 8776035: Add PanelOverflowStrip to handle panel overflow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel.h » ('j') | chrome/browser/ui/panels/panel.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/base_panel_browser_test.cc
diff --git a/chrome/browser/ui/panels/base_panel_browser_test.cc b/chrome/browser/ui/panels/base_panel_browser_test.cc
index 626d6b731ca4a2c5eee6f0120188ba3659907e24..89ed381fbe86c4db6c37e05c3a5d1098a65e30da 100644
--- a/chrome/browser/ui/panels/base_panel_browser_test.cc
+++ b/chrome/browser/ui/panels/base_panel_browser_test.cc
@@ -311,10 +311,15 @@ Panel* BasePanelBrowserTest::CreatePanelWithParams(
#endif
}
MessageLoopForUI::current()->RunAllPending();
+
// More waiting, because gaining or losing focus may require inter-process
// asynchronous communication, and it is not enough to just run the local
// message loop to make sure this activity has completed.
- WaitForPanelActiveState(panel, params.show_flag);
+ // Note that overflow panel will not be shown as active.
jennb 2011/12/02 21:16:58 Let's not allow tests create panels that start out
jianli 2011/12/02 23:23:46 Removed.
+ ActiveState show_flag = params.show_flag;
+ if (panel->expansion_state() == Panel::IN_OVERFLOW)
+ show_flag = SHOW_AS_INACTIVE;
+ WaitForPanelActiveState(panel, show_flag);
// On Linux, window size is not available right away and we should wait
// before moving forward with the test.
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel.h » ('j') | chrome/browser/ui/panels/panel.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698