Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 8776034: Remove a touchui section from chrome_browser.gypi (Closed)

Created:
9 years ago by Emmanuel Saint-loubert-Bié
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, bryeung
Visibility:
Public.

Description

Remove a touchui section from chrome_browser.gypi This is bryeung CL from http://codereview.chromium.org/8748013/ which was approved by sky and failed on the commit-bot. It also improves the logic of one of my later CL in the same area. TBR=sky@chromium.org BUG=105046 TEST=grep *.ninja for relevant files in a large variety of configurations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112640

Patch Set 1 #

Patch Set 2 : Missing file exclusion added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8776034/1001
9 years ago (2011-12-02 03:28:06 UTC) #1
commit-bot: I haz the power
9 years ago (2011-12-02 05:09:37 UTC) #2
Change committed as 112640

Powered by Google App Engine
This is Rietveld 408576698