Issue 8776032: Let store buffer start out small for a 1Mbyte saving in boot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8776032: Let store buffer start out small for a 1Mbyte saving in boot (Closed)

Created:
9 years ago by Erik Corry

Modified:
9 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Let store buffer start out small for a 1Mbyte saving in boot memory use (2Mbyte on x64). Committed: http://code.google.com/p/v8/source/detail?r=10143

Patch Set 2 : '' #

Total comments: 4

Created: 9 years ago

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -18 lines)
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments
M	src/platform.h	View	1 chunk	+4 lines, -0 lines	0 comments
M	src/platform-posix.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/platform-win32.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/store-buffer.h	View	3 chunks	+4 lines, -1 line	0 comments
M	src/store-buffer.cc	View	7 chunks	+39 lines, -15 lines	4 comments
M	test/cctest/test-mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode73 src/store-buffer.cc:73: if (initial_length == 0) initial_length = ...

9 years ago (2011-12-02 13:38:52 UTC) #3

Erik Corry

9 years ago (2011-12-02 14:07:27 UTC) #4

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc
File src/store-buffer.cc (right):

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode73
src/store-buffer.cc:73: if (initial_length == 0) initial_length = 1;
On 2011/12/02 13:38:52, Michael Starzinger wrote:
> Can we change this into ASSERT(initial_length != 0)?

Refactored in a slightly different way.

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode176
src/store-buffer.cc:176: reinterpret_cast<void*>(old_limit_), grow *
kPointerSize, false));
On 2011/12/02 13:38:52, Michael Starzinger wrote:
> Can we put each argument on a separate line like with the two occurences
above?

Done.

Expand Messages | Collapse Messages

Issue 8776032: Let store buffer start out small for a 1Mbyte saving in boot (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages