Issue 8776032: Let store buffer start out small for a 1Mbyte saving in boot

Issue 8776032: Let store buffer start out small for a 1Mbyte saving in boot (Closed)

Created:
9 years ago by Erik Corry

Modified:
9 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Let store buffer start out small for a 1Mbyte saving in boot memory use (2Mbyte on x64). Committed: http://code.google.com/p/v8/source/detail?r=10143

Patch Set 2 : '' #

Total comments: 4

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -18 lines)			Patch
M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/platform-posix.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/platform-win32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/store-buffer.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	src/store-buffer.cc	View	1	7 chunks	+39 lines, -15 lines	4 comments	Download
M	test/cctest/test-mark-compact.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode73 src/store-buffer.cc:73: if (initial_length == 0) initial_length = ...

9 years ago (2011-12-02 13:38:52 UTC) #3

Erik Corry

9 years ago (2011-12-02 14:07:27 UTC) #4

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc
File src/store-buffer.cc (right):

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode73
src/store-buffer.cc:73: if (initial_length == 0) initial_length = 1;
On 2011/12/02 13:38:52, Michael Starzinger wrote:
> Can we change this into ASSERT(initial_length != 0)?

Refactored in a slightly different way.

http://codereview.chromium.org/8776032/diff/1011/src/store-buffer.cc#newcode176
src/store-buffer.cc:176: reinterpret_cast<void*>(old_limit_), grow *
kPointerSize, false));
On 2011/12/02 13:38:52, Michael Starzinger wrote:
> Can we put each argument on a separate line like with the two occurences
above?

Done.

Expand Messages | Collapse Messages