Issue 8776030: Add IPCs to allow assistive technology to scroll the page

Issue 8776030: Add IPCs to allow assistive technology to scroll the page (Closed)

Created:
9 years ago by dmazzoni

Modified:
9 years ago

Reviewers:
David Tseng, dtseng, jam

CC:
chromium-reviews, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, penghuang+watch_chromium.org, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Su, zork+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add IPCs to allow assistive technology to scroll the page or select text. BUG=104468, 104469 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112817

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -0 lines)			Patch
M	content/browser/accessibility/browser_accessibility_manager.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_manager.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_win.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_accessibility.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_accessibility.cc	View	1	4 chunks	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

i can only do rubberstamp lgtm as an owner, since I don't understand the accessibility ...

9 years ago (2011-12-02 00:01:02 UTC) #2

dmazzoni

Sorry, should have included dtseng from the beginning. dtseng: review overall change for accessibility jam: ...

9 years ago (2011-12-02 00:05:00 UTC) #3

David Tseng

lgtm http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_accessibility.cc File content/renderer/renderer_accessibility.cc (right): http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_accessibility.cc#newcode407 content/renderer/renderer_accessibility.cc:407: PostAccessibilityNotification( Is the above call blocking? Wondering if ...

9 years ago (2011-12-02 17:55:51 UTC) #4

dmazzoni

9 years ago (2011-12-02 20:06:02 UTC) #5

http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_acces...
File content/renderer/renderer_accessibility.cc (right):

http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_acces...
content/renderer/renderer_accessibility.cc:407: PostAccessibilityNotification(
On 2011/12/02 17:55:51, David Tseng wrote:
> Is the above call blocking? Wondering if this PostAccessibilityNotification
> better belongs there.

The right solution is for WebKit to fire a notification when the scroll position
actually changes. I added a TODO with a link to the WebKit bug:
https://bugs.webkit.org/show_bug.cgi?id=73460

http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_acces...
File content/renderer/renderer_accessibility.h (right):

http://codereview.chromium.org/8776030/diff/1/content/renderer/renderer_acces...
content/renderer/renderer_accessibility.h:87: void OnChangeScrollPosition(int
acc_obj_id, int scroll_x, int scroll_y);
On 2011/12/02 17:55:51, David Tseng wrote:
> nit: Do we want to keep these alphabetized?

Done.

Expand Messages | Collapse Messages