Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: WATCHLISTS

Issue 8776027: Update WATCHLIST to point to ui/views/* instead of views/* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Watchlist Rules 5 # Watchlist Rules
6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists 6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists
7 7
8 8
9 { 9 {
10 'WATCHLIST_DEFINITIONS': { 10 'WATCHLIST_DEFINITIONS': {
11 'this_file': { 11 'this_file': {
12 'filepath': '^WATCHLISTS$', 12 'filepath': '^WATCHLISTS$',
13 }, 13 },
14 'valgrind': { 14 'valgrind': {
15 'filepath': 'valgrind', 15 'filepath': 'valgrind',
16 }, 16 },
17 'mac': { 17 'mac': {
18 'filepath': 'cocoa|\.mm$|(_mac|_posix)\.(cc|h)$', 18 'filepath': 'cocoa|\.mm$|(_mac|_posix)\.(cc|h)$',
19 }, 19 },
20 'base': { 20 'base': {
21 'filepath': '^base/.*', 21 'filepath': '^base/.*',
22 }, 22 },
23 'extension': { 23 'extension': {
24 'filepath': 'extension', 24 'filepath': 'extension',
25 }, 25 },
26 'views': { 26 'views': {
27 # Applies to all files and subdirs within this directory. 27 # Applies to all files and subdirs within this directory.
28 'filepath': '^views/.*|'\ 28 'filepath': '^ui/views/.*',
29 '^ui/views/.*',
30 }, 29 },
31 'aura': { 30 'aura': {
32 'filepath': 'ui/aura/.*|'\ 31 'filepath': 'ui/aura/.*|'\
33 'ui/aura_shell/.*', 32 'ui/aura_shell/.*',
34 }, 33 },
35 'views_core': { 34 'views_core': {
36 'filepath': 'views/view.h|'\ 35 'filepath': 'ui/views/view.h|'\
37 'views/view.cc|'\ 36 'ui/views/view.cc|'\
38 'views/widget/.*', 37 'ui/views/widget/.*',
39 }, 38 },
40 'browser': { 39 'browser': {
41 'filepath': 'chrome/browser/.*', 40 'filepath': 'chrome/browser/.*',
42 }, 41 },
43 'browser_main': { 42 'browser_main': {
44 'filepath': 'chrome/browser/browser_main.cc', 43 'filepath': 'chrome/browser/browser_main.cc',
45 }, 44 },
46 'browser_resources': { 45 'browser_resources': {
47 'filepath': 'chrome/browser/resources/.*', 46 'filepath': 'chrome/browser/resources/.*',
48 }, 47 },
49 'bubble': { 48 'bubble': {
50 'filepath': 'views/bubble/.*|'\ 49 'filepath': 'ui/views/bubble/.*|'\
51 'chrome/browser/ui/views/bubble/.*', 50 'chrome/browser/ui/views/bubble/.*',
52 }, 51 },
53 'chromeos_login': { 52 'chromeos_login': {
54 'filepath': 'chrome/browser/chromeos/login/.*|'\ 53 'filepath': 'chrome/browser/chromeos/login/.*|'\
55 'chrome/browser/ui/webui/chromeos/login/.*|'\ 54 'chrome/browser/ui/webui/chromeos/login/.*|'\
56 'chrome/browser/resources/chromeos/login/.*', 55 'chrome/browser/resources/chromeos/login/.*',
57 }, 56 },
58 'content': { 57 'content': {
59 'filepath': 'content/.*', 58 'filepath': 'content/.*',
60 }, 59 },
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 'filepath': 'media/.*|third_party/(ffmpeg|openmax)/.*|webmediaplayer|'\ 119 'filepath': 'media/.*|third_party/(ffmpeg|openmax)/.*|webmediaplayer|'\
121 'audio_message_filter|video_layer', 120 'audio_message_filter|video_layer',
122 }, 121 },
123 'ipc': { 122 'ipc': {
124 'filepath': 'ipc/ipc.*', 123 'filepath': 'ipc/ipc.*',
125 }, 124 },
126 'linux-sandboxing': { 125 'linux-sandboxing': {
127 'filepath': 'sandbox/linux/.*', 126 'filepath': 'sandbox/linux/.*',
128 }, 127 },
129 'sync': { 128 'sync': {
130 'filepath': 'chrome/browser/sync/.*|chrome/browser/views/sync/.*', 129 'filepath': 'chrome/browser/sync/.*',
131 }, 130 },
132 'layout_tests': { 131 'layout_tests': {
133 'filepath': 'webkit/(tools|data)/(layout_tests|test_shell)/.*', 132 'filepath': 'webkit/(tools|data)/(layout_tests|test_shell)/.*',
134 }, 133 },
135 'tools': { 134 'tools': {
136 'filepath': 'tools/.*', 135 'filepath': 'tools/.*',
137 }, 136 },
138 'tests': { 137 'tests': {
139 'filepath': 'apitest|unittest|browsertest|uitest|chrome/test/.*', 138 'filepath': 'apitest|unittest|browsertest|uitest|chrome/test/.*',
140 }, 139 },
141 'automation': { 140 'automation': {
142 'filepath': 'chrome/browser/automation/.*|chrome/test/automation/.*', 141 'filepath': 'chrome/browser/automation/.*|chrome/test/automation/.*',
143 }, 142 },
144 'chrome_frame': { 143 'chrome_frame': {
145 'filepath': 'chrome_frame/.*', 144 'filepath': 'chrome_frame/.*',
146 }, 145 },
147 'nacl': { 146 'nacl': {
148 'filepath': 'chrome/nacl/.*|chrome/test/nacl/.*|'\ 147 'filepath': 'chrome/nacl/.*|chrome/test/nacl/.*|'\
149 'chrome/browser/nacl_host/.*|chrome/common/nacl.*', 148 'chrome/browser/nacl_host/.*|chrome/common/nacl.*',
150 }, 149 },
151 'appcache': { 150 'appcache': {
152 'filepath': 'appcache/.*', 151 'filepath': 'appcache/.*',
153 }, 152 },
154 'gpu': { 153 'gpu': {
155 'filepath': 'gpu/.*', 154 'filepath': 'gpu/.*',
156 }, 155 },
157 'locale_settings': { 156 'locale_settings': {
158 'filepath': 'chrome/app/resources/locale_settings.*', 157 'filepath': 'chrome/app/resources/locale_settings.*',
159 }, 158 },
160 'options_dialog_content': {
161 'filepath': 'chrome/browser/views/options/content_page_view.h|'\
162 'chrome/browser/views/options/general_page_view.h',
163 },
164 'chromeos': { 159 'chromeos': {
165 'filepath': 'chrome/browser/chromeos/.*', 160 'filepath': 'chrome/browser/chromeos/.*',
166 }, 161 },
167 'chromeos_webui': { 162 'chromeos_webui': {
168 'filepath': 'chrome/browser/ui/webui/chromeos/.*|'\ 163 'filepath': 'chrome/browser/ui/webui/chromeos/.*|'\
169 'chrome/browser/resources/chromeos/.*', 164 'chrome/browser/resources/chromeos/.*',
170 }, 165 },
171 'npapi_headers': { 166 'npapi_headers': {
172 'filepath': 'third_party/npapi/bindings/.*', 167 'filepath': 'third_party/npapi/bindings/.*',
173 }, 168 },
174 'remoting': { 169 'remoting': {
175 'filepath': 'remoting/.*', 170 'filepath': 'remoting/.*',
176 }, 171 },
177 'domui_options': { 172 'domui_options': {
178 'filepath': 'chrome/browser/resources/options/.*|'\ 173 'filepath': 'chrome/browser/resources/options/.*|'\
179 'chrome/browser/resources/options.html|'\ 174 'chrome/browser/resources/options.html|'\
180 'chrome/browser/dom_ui/options/.*', 175 'chrome/browser/ui/webui/options/.*',
181 }, 176 },
182 'ntp': { 177 'ntp': {
183 'filepath': 'chrome/browser/resources/ntp/.*|'\ 178 'filepath': 'chrome/browser/resources/ntp/.*|'\
184 'chrome/browser/resources/ntp4/.*|'\ 179 'chrome/browser/resources/ntp4/.*|'\
185 'chrome/browser/resources/touch_ntp/.*|'\ 180 'chrome/browser/resources/touch_ntp/.*|'\
186 'chrome/browser/resources/touch_ntp/.*|'\ 181 'chrome/browser/resources/touch_ntp/.*|'\
187 'chrome/browser/ui/webui/ntp/.*', 182 'chrome/browser/ui/webui/ntp/.*',
188 }, 183 },
189 'cookie_monster': { 184 'cookie_monster': {
190 'filepath': 'net/base/cookie_.*|'\ 185 'filepath': 'net/base/cookie_.*|'\
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 '|chrome/browser/chromeos/'\ 263 '|chrome/browser/chromeos/'\
269 'xinput_hierarchy_changed_event_listener\..*' \ 264 'xinput_hierarchy_changed_event_listener\..*' \
270 '|chrome/browser/chromeos/wm_.*' \ 265 '|chrome/browser/chromeos/wm_.*' \
271 '|ui/base/x/.*' 266 '|ui/base/x/.*'
272 }, 267 },
273 'accessibility': { 268 'accessibility': {
274 'filepath': 'chrome/browser/accessibility/.*' \ 269 'filepath': 'chrome/browser/accessibility/.*' \
275 '|content/browser/accessibility/.*' \ 270 '|content/browser/accessibility/.*' \
276 '|chrome/.*accessib.*' \ 271 '|chrome/.*accessib.*' \
277 '|ui/base/accessibility/.*' \ 272 '|ui/base/accessibility/.*' \
278 '|views/accessibility/.*' 273 '|ui/views/accessibility/.*'
279 }, 274 },
280 'tools_emacs': { 275 'tools_emacs': {
281 'filepath': 'tools/emacs/.*', 276 'filepath': 'tools/emacs/.*',
282 }, 277 },
283 'browser_compositor': { 278 'browser_compositor': {
284 'filepath': 'ui/gfx/compositor/.*' 279 'filepath': 'ui/gfx/compositor/.*'
285 }, 280 },
286 'browser_gl': { 281 'browser_gl': {
287 'filepath': 'ui/gfx/gl/.*' 282 'filepath': 'ui/gfx/gl/.*'
288 }, 283 },
289 'textinput': { 284 'textinput': {
290 'filepath': 'content/browser/renderer_host/gtk_im.*'\ 285 'filepath': 'content/browser/renderer_host/gtk_im.*'\
291 '|content/browser/renderer_host/gtk_key.*'\ 286 '|content/browser/renderer_host/gtk_key.*'\
292 '|content/browser/renderer_host/render_widget_host_view.*'\ 287 '|content/browser/renderer_host/render_widget_host_view.*'\
293 '|content/browser/renderer_host/text_input.*'\ 288 '|content/browser/renderer_host/text_input.*'\
294 '|ui/base/ime/.*'\ 289 '|ui/base/ime/.*'\
295 '|ui/base/gtk/event.*'\ 290 '|ui/base/gtk/event.*'\
296 '|ui/base/gtk/gtk_im.*'\ 291 '|ui/base/gtk/gtk_im.*'\
297 '|ui/base/keycodes/.*'\ 292 '|ui/base/keycodes/.*'\
298 '|ui/base/win/ime.*'\ 293 '|ui/base/win/ime.*'\
299 '|ui/views/ime/.*'\ 294 '|ui/views/controls/textfield/.*'\
300 '|views/controls/textfield/.*' 295 '|ui/views/ime/.*'
301 }, 296 },
302 'textinput_chromeos': { 297 'textinput_chromeos': {
303 'filepath': 'chrome/browser/chromeos/input_method/.*'\ 298 'filepath': 'chrome/browser/chromeos/input_method/.*'\
304 '|chrome/browser/chromeos/extensions/input_method.*'\ 299 '|chrome/browser/chromeos/extensions/input_method.*'\
305 '|chrome/browser/chromeos/status/input_method.*'\ 300 '|chrome/browser/chromeos/status/input_method.*'\
306 '|chrome/browser/extensions/extension_input_.*'\ 301 '|chrome/browser/extensions/extension_input_.*'\
307 '|chrome/browser/resources/keyboard.*'\ 302 '|chrome/browser/resources/keyboard.*'\
308 '|chrome/browser/resources/options/language.*'\ 303 '|chrome/browser/resources/options/language.*'\
309 '|chrome/browser/ui/webui/options/'\ 304 '|chrome/browser/ui/webui/options/'\
310 'chromeos/.*(language|keyboard).*'\ 305 'chromeos/.*(language|keyboard).*'\
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 'akalin@chromium.org', 'rsimha@chromium.org'], 359 'akalin@chromium.org', 'rsimha@chromium.org'],
365 'tools': ['pam+watch@chromium.org'], 360 'tools': ['pam+watch@chromium.org'],
366 'tests': ['phajdan.jr@chromium.org'], 361 'tests': ['phajdan.jr@chromium.org'],
367 'automation': ['phajdan.jr@chromium.org', 'kkania@chromium.org', 362 'automation': ['phajdan.jr@chromium.org', 'kkania@chromium.org',
368 'robertshield@chromium.org'], 363 'robertshield@chromium.org'],
369 'chrome_frame': ['amit@chromium.org', 'robertshield@chromium.org'], 364 'chrome_frame': ['amit@chromium.org', 'robertshield@chromium.org'],
370 'nacl': ['native-client-reviews@googlegroups.com'], 365 'nacl': ['native-client-reviews@googlegroups.com'],
371 'appcache': ['michaeln@chromium.org'], 366 'appcache': ['michaeln@chromium.org'],
372 'gpu': ['apatrick@chromium.org'], 367 'gpu': ['apatrick@chromium.org'],
373 'locale_settings': ['finnur+watch@chromium.org'], 368 'locale_settings': ['finnur+watch@chromium.org'],
374 'options_dialog_content': ['finnur+watch@chromium.org'],
375 'chromeos': ['davemoore+watch@chromium.org', 'stevenjb+watch@chromium.org', 369 'chromeos': ['davemoore+watch@chromium.org', 'stevenjb+watch@chromium.org',
376 'nkostylev+watch@chromium.org'], 370 'nkostylev+watch@chromium.org'],
377 'chromeos_webui': ['nkostylev+watch@chromium.org'], 371 'chromeos_webui': ['nkostylev+watch@chromium.org'],
378 'npapi_headers': ['stuartmorgan@chromium.org'], 372 'npapi_headers': ['stuartmorgan@chromium.org'],
379 'remoting': ['garykac+watch@chromium.org', 373 'remoting': ['garykac+watch@chromium.org',
380 'hclam+watch@chromium.org', 374 'hclam+watch@chromium.org',
381 'jamiewalch+watch@chromium.org', 375 'jamiewalch+watch@chromium.org',
382 'lambroslambrou+watch@chromium.org', 376 'lambroslambrou+watch@chromium.org',
383 'sergeyu+watch@chromium.org', 377 'sergeyu+watch@chromium.org',
384 'simonmorris+watch@chromium.org', 378 'simonmorris+watch@chromium.org',
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 'browser_gl': ['dhollowa+watch@chromium.org'], 430 'browser_gl': ['dhollowa+watch@chromium.org'],
437 'textinput': ['penghuang+watch@chromium.org', 431 'textinput': ['penghuang+watch@chromium.org',
438 'suzhe@chromium.org', 432 'suzhe@chromium.org',
439 'yusukes+watch@chromium.org'], 433 'yusukes+watch@chromium.org'],
440 'textinput_chromeos': ['yusukes+watch@chromium.org'], 434 'textinput_chromeos': ['yusukes+watch@chromium.org'],
441 'omnibox': ['suzhe@chromium.org'], 435 'omnibox': ['suzhe@chromium.org'],
442 'message_loop': ['sadrul@chromium.org'], 436 'message_loop': ['sadrul@chromium.org'],
443 'clipboard': ['dcheng@chromium.org'], 437 'clipboard': ['dcheng@chromium.org'],
444 }, 438 },
445 } 439 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698