Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: webkit/appcache/appcache_service.cc

Issue 8776024: base::Bind: Convert AppCacheService::GetAllAppCacheInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_service.h ('k') | webkit/appcache/appcache_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_service.cc
diff --git a/webkit/appcache/appcache_service.cc b/webkit/appcache/appcache_service.cc
index e30df560244826b5e6eff97cc99f2b27bac9bfde..f48faf8704dffc6cb8f06bf10fb34fc57d5fca90 100644
--- a/webkit/appcache/appcache_service.cc
+++ b/webkit/appcache/appcache_service.cc
@@ -299,12 +299,12 @@ void AppCacheService::DeleteOriginHelper::CacheCompleted(bool success) {
// GetInfoHelper -------
-class AppCacheService::GetInfoHelper : AsyncHelper {
+class AppCacheService::GetInfoHelper : NewAsyncHelper {
public:
GetInfoHelper(
AppCacheService* service, AppCacheInfoCollection* collection,
- net::OldCompletionCallback* callback)
- : AsyncHelper(service, callback), collection_(collection) {
+ const net::CompletionCallback& callback)
+ : NewAsyncHelper(service, callback), collection_(collection) {
}
virtual void Start() {
@@ -316,6 +316,7 @@ class AppCacheService::GetInfoHelper : AsyncHelper {
virtual void OnAllInfo(AppCacheInfoCollection* collection);
scoped_refptr<AppCacheInfoCollection> collection_;
+
DISALLOW_COPY_AND_ASSIGN(GetInfoHelper);
};
@@ -506,8 +507,9 @@ void AppCacheService::CanHandleMainResourceOffline(
helper->Start();
}
-void AppCacheService::GetAllAppCacheInfo(AppCacheInfoCollection* collection,
- net::OldCompletionCallback* callback) {
+void AppCacheService::GetAllAppCacheInfo(
+ AppCacheInfoCollection* collection,
+ const net::CompletionCallback& callback) {
DCHECK(collection);
GetInfoHelper* helper = new GetInfoHelper(this, collection, callback);
helper->Start();
« no previous file with comments | « webkit/appcache/appcache_service.h ('k') | webkit/appcache/appcache_test_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698