Issue 8776024: base::Bind: Convert AppCacheService::GetAllAppCacheInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8776024: base::Bind: Convert AppCacheService::GetAllAppCacheInfo. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
csilv

CC:
chromium-reviews, michaeln, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert AppCacheService::GetAllAppCacheInfo. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112622

Patch Set 2 : Test build fix. #

Total comments: 2

Patch Set 3 : Review fix. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -32 lines)			Patch
M	chrome/browser/browsing_data_appcache_helper.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data_appcache_helper.cc	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	webkit/appcache/appcache_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_service.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	webkit/appcache/appcache_test_helper.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/appcache/appcache_test_helper.cc	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	webkit/appcache/view_appcache_internals_job.cc	View		3 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8776024/diff/2001/webkit/appcache/appcache_test_helper.cc File webkit/appcache/appcache_test_helper.cc (right): http://codereview.chromium.org/8776024/diff/2001/webkit/appcache/appcache_test_helper.cc#newcode62 webkit/appcache/appcache_test_helper.cc:62: ; help this semi-colon find its way home

9 years ago (2011-12-02 00:59:30 UTC) #2

James Hawkins

9 years ago (2011-12-02 01:04:52 UTC) #3

http://codereview.chromium.org/8776024/diff/2001/webkit/appcache/appcache_tes...
File webkit/appcache/appcache_test_helper.cc (right):

http://codereview.chromium.org/8776024/diff/2001/webkit/appcache/appcache_tes...
webkit/appcache/appcache_test_helper.cc:62: ;
On 2011/12/02 00:59:30, csilv wrote:
> help this semi-colon find its way home

Get along little doggy.