Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pnacl/build.sh

Issue 8776023: Switch the nop pnacl x86-64 IRT shim to the real one generated from IDL. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pnacl/build.sh
diff --git a/pnacl/build.sh b/pnacl/build.sh
index 64f2a07a4271ee937f47fa9764c0406086367304..3ca8c4e6a5f3effbf5ceb59ecc8e57179eadc210 100755
--- a/pnacl/build.sh
+++ b/pnacl/build.sh
@@ -3048,13 +3048,17 @@ sdk-irt-shim() {
# the pnacl toolchain to depend on it.
StepBanner "SDK" "IRT Shim"
spushd "${NACL_ROOT}"
+ # NOTE: We specify bitcode=1, but it is really using nacl-gcc to build
+ # the library (it's only bitcode=1 because it's part of the pnacl sdk).
RunWithLog "sdk.irt.shim" \
robertm 2011/12/01 22:55:43 this looks like churn why not stick with the origi
jvoung - send to chromium... 2011/12/01 23:35:34 I think this was to make the implicit-libs change
robertm 2011/12/01 23:58:43 Ok that is fine then - but maybe add a brief comm
./scons -j${PNACL_CONCURRENCY} \
+ bitcode=1 \
platform=x86-64 \
naclsdk_validate=0 \
--verbose \
pnacl_irt_shim
- local outdir="${SCONS_OUT}"/nacl-x86-64/obj/src/untrusted/pnacl_irt_shim
+ local out_dir_prefix="${SCONS_OUT}"/nacl-x86-64-pnacl-clang
+ local outdir="${out_dir_prefix}"/obj/src/untrusted/pnacl_irt_shim
mkdir -p "${INSTALL_LIB_X8664}"
cp "${outdir}"/libpnacl_irt_shim.a "${INSTALL_LIB_X8664}"
spopd

Powered by Google App Engine
This is Rietveld 408576698