fix tab restore service crash

fix tab restore service crash

if entries_ is larger than kMaxEntries, some pointer math goes askew

BUG=106082
TEST=included


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112955

[sky, 2011-12-01 21:46:49]

http://codereview.chromium.org/8776018/diff/2001/chrome/browser/sessions/tab_...
File chrome/browser/sessions/tab_restore_service.cc (right):

http://codereview.chromium.org/8776018/diff/2001/chrome/browser/sessions/tab_...
chrome/browser/sessions/tab_restore_service.cc:541: PruneEntries();
How come we only prune if we're notifying?

[Evan Stade, 2011-12-02 02:22:26]

http://codereview.chromium.org/8776018/diff/2001/chrome/browser/sessions/tab_...
File chrome/browser/sessions/tab_restore_service.cc (right):

http://codereview.chromium.org/8776018/diff/2001/chrome/browser/sessions/tab_...
chrome/browser/sessions/tab_restore_service.cc:541: PruneEntries();
On 2011/12/01 21:46:49, sky wrote:
> How come we only prune if we're notifying?

I did this because it was how the code worked before, but I guess we should
always do it.

[Evan Stade, 2011-12-02 20:43:57]

updated

[sky, 2011-12-02 20:56:48]

LGTM

[commit-bot: I haz the power, 2011-12-02 21:04:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/8776018/3004

[commit-bot: I haz the power, 2011-12-03 00:28:35]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 112804, job name
was 8776018-3004 (retry) (previous was lost) (previous was lost) (previous was
lost).

[commit-bot: I haz the power, 2011-12-05 02:08:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/8776018/3004

[commit-bot: I haz the power, 2011-12-05 03:24:44]

Change committed as 112955