Issue 8776015: [ntp4] Remove last remnants of bookmarks page implementation.

Issue 8776015: [ntp4] Remove last remnants of bookmarks page implementation. (Closed)

Created:
9 years ago by csilv

Modified:
9 years ago

Reviewers:
Dan Beam, Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[ntp4] Remove last remnants of bookmarks page implementation. BUG=105941 TEST=Verify NTP4 still works, tree green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112809

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

my comment got deleted somehow http://codereview.chromium.org/8776015/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.h File chrome/browser/ui/webui/ntp/new_tab_page_handler.h (left): http://codereview.chromium.org/8776015/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.h#oldcode65 chrome/browser/ui/webui/ntp/new_tab_page_handler.h:65: BOOKMARKS_PAGE_ID = 3 << ...

9 years ago (2011-12-01 23:16:35 UTC) #4

csilv

http://codereview.chromium.org/8776015/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.h File chrome/browser/ui/webui/ntp/new_tab_page_handler.h (left): http://codereview.chromium.org/8776015/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.h#oldcode65 chrome/browser/ui/webui/ntp/new_tab_page_handler.h:65: BOOKMARKS_PAGE_ID = 3 << kPageIdOffset, On 2011/12/01 23:16:35, Evan ...

9 years ago (2011-12-02 01:00:33 UTC) #5

lgtm

Expand Messages | Collapse Messages