Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 8776009: Chrome for arm seems to make the implicit assumption that (Closed)

Created:
9 years ago by robertm
Modified:
9 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Chrome for arm seems to make the implicit assumption that chromeos is the target in a few places. Make this assumption explicit. Also enable nacl in the non-chromeos case so we can start debugging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114039

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/content_common.gypi View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertm
PTAL
9 years ago (2011-12-08 21:59:52 UTC) #1
Mark Mentovai
LGTM if all the try flavors like it.
9 years ago (2011-12-08 22:10:38 UTC) #2
sehr (please use chromium)
On 2011/12/08 22:10:38, Mark Mentovai wrote: > LGTM if all the try flavors like it. ...
9 years ago (2011-12-09 16:56:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertm@google.com/8776009/20001
9 years ago (2011-12-12 16:44:21 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-12 18:12:56 UTC) #5
Change committed as 114039

Powered by Google App Engine
This is Rietveld 408576698