Issue 8776007: Start/stop WebKitThread from BrowserMainLoop like other BrowserThreads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8776007: Start/stop WebKitThread from BrowserMainLoop like other BrowserThreads. (Closed)

Created:
9 years ago by Jói

Modified:
9 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start/stop WebKitThread from BrowserMainLoop like other BrowserThreads. Move WebKitThread to the content namespace. Re-order thread objects in BrowserMainLoop declaration to match instantiation order. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112682

Patch Set 1 #

Patch Set 2 : merge to head. #

Patch Set 3 : Merge to head. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -31 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/browser_main_loop.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View		5 chunks	+19 lines, -10 lines	0 comments	Download
M	content/browser/in_process_webkit/webkit_thread.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/in_process_webkit/webkit_thread.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/in_process_webkit/webkit_thread_unittest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.h	View	1 2	3 chunks	+0 lines, -8 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.cc	View	1 2	3 chunks	+0 lines, -3 lines	0 comments	Download
M	content/shell/shell_browser_main.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8776007/3002

9 years ago (2011-12-02 11:07:35 UTC) #3

Change committed as 112682

Expand Messages | Collapse Messages