Clear DNS cache and passive log collected on incognito close.

Clear DNS cache and passive log collector on incognito close.

The call that used to do this was made from the predictor, and
was accidentally removed during a predictor refactoring
(http://codereview.chromium.org/7467012/)

BUG=69732
TEST=open incognito window, go somewhere, close the window,
open net-internals, and check that no hints of what was
done during incognito mode remain.

committed=http://src.chromium.org/viewvc/chrome?view=rev&revision=113324

[mmenke, 2011-12-05 18:59:54]

http://codereview.chromium.org/8775067/diff/18001/chrome/test/data/webui/net_...
File chrome/test/data/webui/net_internals/net_internals_test.js (right):

http://codereview.chromium.org/8775067/diff/18001/chrome/test/data/webui/net_...
chrome/test/data/webui/net_internals/net_internals_test.js:427: // incognito in
exitence.  Returns immediately.
Added these here because if/when/whatever I added tests for the events tab,
we'll want these there, too.

[mmenke, 2011-12-05 19:01:48]

Two more things:

I suggest you compare patchsets 3 and 4 when reviewing the browsertest.

Since this is a serious regression for people who take Incognito mode seriously,
I'd like this in for M17.  If you can't review it today, I can always try to get
merge permissions, of course.

[eroman, 2011-12-05 21:10:48]

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/io_thread.h
File chrome/browser/io_thread.h (right):

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/io_thread.h#...
chrome/browser/io_thread.h:126: void ChangedToOnTheRecordOnIOThread();
Can this be private?

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals_ui_browsertest.cc (right):

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals_ui_browsertest.cc:273: incognito_browser_
= NULL;
What code is responsible for freeing the Browser* object? does CloseAllTabs() do
that?

[eroman, 2011-12-05 21:10:56]

lgtm

[mmenke, 2011-12-05 22:28:00]

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/io_thread.h
File chrome/browser/io_thread.h (right):

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/io_thread.h#...
chrome/browser/io_thread.h:126: void ChangedToOnTheRecordOnIOThread();
On 2011/12/05 21:10:49, eroman wrote:
> Can this be private?

Done.

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals_ui_browsertest.cc (right):

http://codereview.chromium.org/8775067/diff/18001/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals_ui_browsertest.cc:273: incognito_browser_
= NULL;
On 2011/12/05 21:10:49, eroman wrote:
> What code is responsible for freeing the Browser* object? does CloseAllTabs()
do
> that?

Browser objects are automatically destroyed once their last tab has been closed,
though the destruction will happen asynchronously.  Added a comment to that
effect.

[commit-bot: I haz the power, 2011-12-05 22:29:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8775067/10026

[commit-bot: I haz the power, 2011-12-05 22:29:28]

Presubmit check for 8775067-10026 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/off_the_record_profile_impl.cc

Presubmit checks took 1.2s to calculate.

[mmenke, 2011-12-05 22:36:18]

+mirandac:  Please review the change to off_the_record_profile_impl.cc.

[mmenke, 2011-12-07 00:18:04]

Guess Miranda's out this week.

+willchan:  Hadn't realized you're a Profile owner.  Please review the chance to
off_the_record.cc.

[willchan no longer on Chromium, 2011-12-07 00:25:55]

lgtm

[commit-bot: I haz the power, 2011-12-07 00:27:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8775067/23001

[commit-bot: I haz the power, 2011-12-07 02:51:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8775067/23001

[commit-bot: I haz the power, 2011-12-07 02:51:27]

Can't apply patch for file
chrome/browser/profiles/off_the_record_profile_impl.cc.
While running patch -p0 --forward --force;
patching file chrome/browser/profiles/off_the_record_profile_impl.cc
Hunk #1 FAILED at 26.
Hunk #2 succeeded at 595 with fuzz 2 (offset 441 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/profiles/off_the_record_profile_impl.cc.rej

[mmenke, 2011-12-07 04:43:28]

Despite the spam, this was landed.  Closing issue.