Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: remoting/webapp/me2mom/debug_log.js

Issue 8775066: The webapp uses localStorage to decide whether logging to the server (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/me2mom/log_to_server.js » ('j') | remoting/webapp/me2mom/log_to_server.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/me2mom/debug_log.js
diff --git a/remoting/webapp/me2mom/debug_log.js b/remoting/webapp/me2mom/debug_log.js
index 7aee65f47ff8c2165b6c9d22d087775c810da08a..3e0fd4716c751d50e5d4b41c4fad6426578640bc 100644
--- a/remoting/webapp/me2mom/debug_log.js
+++ b/remoting/webapp/me2mom/debug_log.js
@@ -664,7 +664,7 @@ remoting.DebugLog.prototype.prettyIqSet = function(action, iq_list) {
/** @type {Node} */
var entry = log.childNodes[0];
if (!this.verifyAttributes(entry, 'role,event-name,session-state,cpu,' +
- 'os-name,browser-version,webapp-version')) {
+ 'os-name,browser-version,webapp-version,id')) {
return false;
}
var role = entry.getAttribute('role');
@@ -676,7 +676,7 @@ remoting.DebugLog.prototype.prettyIqSet = function(action, iq_list) {
return false;
}
var session_state = entry.getAttribute('session-state');
- this.prettyIqHeading(action, '?', 'set session-state ' + session_state,
+ this.prettyIqHeading(action, '?', 'log session-state ' + session_state,
null);
var os_name = entry.getAttribute('os-name');
@@ -685,6 +685,10 @@ remoting.DebugLog.prototype.prettyIqSet = function(action, iq_list) {
var webapp_version = entry.getAttribute('webapp-version');
this.logIndent(1, os_name + ' ' + cpu + ' Chromium_v' + browser_version +
' Chromoting_v' + webapp_version);
+ var remoting_id = entry.getAttribute('id');
+ if (remoting_id) {
+ this.logIndent(1, 'id: ' + remoting_id);
Jamie 2011/12/02 20:44:20 Do we want to treat id differently to all the othe
simonmorris 2011/12/02 21:05:58 I think most of the other parameters will also be
+ }
return true;
}
}
« no previous file with comments | « no previous file | remoting/webapp/me2mom/log_to_server.js » ('j') | remoting/webapp/me2mom/log_to_server.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698