Remove suppression. This has been fixed in WebKit and rolled into Chrome.

Remove suppression. This has been fixed in WebKit and rolled into Chrome.

BUG=104749
TEST=valgrind bots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112768

[cbentzel, 2011-12-02 20:10:08]

Which webkit revision fixed this?

I only ask because there were problems such as crbug.com/75604 that were
related, and I saw the stack well after the patches associated with that
bug were rolled in from webkit.

On Fri, Dec 2, 2011 at 3:06 PM, <simonjam@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> Remove suppression. This has been fixed in WebKit and rolled into Chrome.
>
> BUG=104749
> TEST=valgrind bots
>
>
> Please review this at
http://codereview.chromium.**org/8775065/<http://codereview.chromium.org/8775...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions.txt
> diff --git a/tools/valgrind/memcheck/**suppressions.txt
> b/tools/valgrind/memcheck/**suppressions.txt
> index 42bacd6a23c5bdead7643e000ac543**7bdbfe9061..**
> a659d585ea5078d7a531b431486c7c**21338f5814 100644
> --- a/tools/valgrind/memcheck/**suppressions.txt
> +++ b/tools/valgrind/memcheck/**suppressions.txt
> @@ -5206,21 +5206,6 @@
>    fun:_**ZNK4base8CallbackIFvvEE3RunEv
>  }
>  {
> -   bug_104749
> -   Memcheck:Unaddressable
> -   ...
> -   fun:_**ZN7WebCore14CachedResource6fin**ishEv
> -   fun:_**ZN7WebCore17SubresourceLoader1**6didFinishLoadingEd
> -   fun:_**ZN7WebCore14ResourceLoader16di**dFinishLoadingEPNS_**
> 14ResourceHandleEd
> -   fun:_**ZN7WebCore22ResourceHandleInte**rnal16didFinishLoadingEPN6WebK*
> *it12WebURLLoaderEd
> -   fun:_ZN11webkit_**glue16WebURLLoaderImpl7Context**
> 18OnCompletedRequestERKN3net16**URLRequestStatusERKSsRKN4base4**TimeE
> -   fun:_ZN12_GLOBAL__N_**112RequestProxy22NotifyComplet**
> edRequestERKN3net16URLRequestS**tatusERKSsRKN4base4TimeE
> -   fun:_**ZN4base8internal15RunnableAdap**terIMN12_GLOBAL__N_**
> 112RequestProxyEFvRKN3net16URL**RequestStatusERKSsRKNS_**
> 4TimeEEE3RunEPS3_S7_S9_SC_
> -   fun:_**ZN4base8internal12InvokeHelper**ILb0EvNS0_**
> 15RunnableAdapterIMN12_GLOBAL_**_N_**112RequestProxyEFvRKN3net16URL**
> RequestStatusERKSsRKNS_**4TimeEEEEFvRKPS4_S8_SA_SD_**
> EE8MakeItSoESG_SJ_S8_SA_SD_
> -   fun:_**ZN4base8internal7InvokerILi4EN**S0_9BindStateINS0_**
> 15RunnableAdapterIMN12_GLOBAL_**_N_**112RequestProxyEFvRKN3net16URL**
> RequestStatusERKSsRKNS_**4TimeEEEEFvPS5_S9_SB_SE_EFvSI_**
> S7_SsSC_EEESJ_E3RunEPNS0_**13BindStateBaseE
> -   fun:_**ZNK4base8CallbackIFvvEE3RunEv
> -}
> -{
>    bug_105907
>    Memcheck:Uninitialized
>    ...
>
>
>

[James Simonsen, 2011-12-02 20:17:08]

On 2011/12/02 20:10:08, cbentzel wrote:
> Which webkit revision fixed this?
> 
> I only ask because there were problems such as crbug.com/75604 that were
> related, and I saw the stack well after the patches associated with that
> bug were rolled in from webkit.

This is a different issue than that bug. This crash was caused by the
refactoring here:

http://trac.webkit.org/changeset/100311

And was fixed here:

http://trac.webkit.org/changeset/101543

[cbentzel, 2011-12-02 20:19:13]

Thanks. LGTM

On Fri, Dec 2, 2011 at 3:17 PM, <simonjam@chromium.org> wrote:

> On 2011/12/02 20:10:08, cbentzel wrote:
>
>> Which webkit revision fixed this?
>>
>
>  I only ask because there were problems such as crbug.com/75604 that were
>> related, and I saw the stack well after the patches associated with that
>> bug were rolled in from webkit.
>>
>
> This is a different issue than that bug. This crash was caused by the
> refactoring here:
>
>
http://trac.webkit.org/**changeset/100311<http://trac.webkit.org/changeset/10...
>
> And was fixed here:
>
>
http://trac.webkit.org/**changeset/101543<http://trac.webkit.org/changeset/10...
>
>
http://codereview.chromium.**org/8775065/<http://codereview.chromium.org/8775...
>