Support incremental-max and sample in Profiler data

Support incremental-max and sample in Profiler data

I also did some cleaning and refactoring in
tracked_objects.  We had a lot of functionality that
has migrated to JS, that we didn't need (a lot of
acccessors that are supplanted by the ToValue()
methods.

I'm anticipating that we'll move to an asynhcronous
collecting of data from the profiler, so that we can
bounce around to various threads and more cleanly
collect samples (without risking races during
data snapshots).  Several of the refactors are
heading in that direction.

r=rtenneti
tbr=jam (for microscopic content change)
BUG=106291, 106293
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112928

[ramant (doing other things), 2011-12-03 17:36:25]

Hi Jim,
  I will keep reviewing. Would appreciate if you could integrate with the trunk.
We have deleted all the code in renderer_tracking.cc. New code is in
child_thread.cc

thanks,
raman

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h#newco...
base/tracked_objects.h:15: #include "base/gtest_prod_util.h"
hi Jim,
  In the tip this file is deleted. New code is in child_thread.cc in content
area.

[ramant (doing other things), 2011-12-03 22:48:39]

lgtm

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h#newco...
base/tracked_objects.h:15: #include "base/gtest_prod_util.h"
On 2011/12/03 17:36:26, ramant wrote:
> hi Jim,
>   In the tip this file is deleted. New code is in child_thread.cc in content
> area.

This comment was in the wrong file. I meant to add it renderer_tracking.cc

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h#newco...
base/tracked_objects.h:359: // instance.  During the scavenging, if
|reset_value| is true, then the
reset_value -> reset_max

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects_unittes...
File base/tracked_objects_unittest.cc (right):

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:509: // see in a moment)
nit: Add a period.

http://codereview.chromium.org/8775061/diff/1009/chrome/renderer/renderer_tra...
File chrome/renderer/renderer_tracking.cc (right):

http://codereview.chromium.org/8775061/diff/1009/chrome/renderer/renderer_tra...
chrome/renderer/renderer_tracking.cc:52:
tracked_objects::ThreadData::ToValue(false));
Hi Jim,
  This file is deleted in the trunk. New code is in child_thread.cc

[jar (doing other things), 2011-12-03 22:53:30]

I uploaded a new CL merged to the tip of tree.

[jar (doing other things), 2011-12-04 00:46:22]

Changes made per comments by rtenneti.

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h#newco...
base/tracked_objects.h:15: #include "base/gtest_prod_util.h"
No problem... I understood.

On 2011/12/03 22:48:39, ramant wrote:
> On 2011/12/03 17:36:26, ramant wrote:
> > hi Jim,
> >   In the tip this file is deleted. New code is in child_thread.cc in content
> > area.
> 
> This comment was in the wrong file. I meant to add it renderer_tracking.cc
>

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects.h#newco...
base/tracked_objects.h:359: // instance.  During the scavenging, if
|reset_value| is true, then the
On 2011/12/03 22:48:39, ramant wrote:
> reset_value -> reset_max

Done.

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects_unittes...
File base/tracked_objects_unittest.cc (right):

http://codereview.chromium.org/8775061/diff/1009/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:509: // see in a moment)
On 2011/12/03 22:48:39, ramant wrote:
> nit: Add a period.

Done.

http://codereview.chromium.org/8775061/diff/1009/chrome/renderer/renderer_tra...
File chrome/renderer/renderer_tracking.cc (right):

http://codereview.chromium.org/8775061/diff/1009/chrome/renderer/renderer_tra...
chrome/renderer/renderer_tracking.cc:52:
tracked_objects::ThreadData::ToValue(false));
On 2011/12/03 22:48:39, ramant wrote:
> Hi Jim,
>   This file is deleted in the trunk. New code is in child_thread.cc

Done.

[Ben Goodger (Google), 2011-12-04 07:22:15]

lgtm