Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 8775060: Debugger step 2 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/debugger.cc ('K') | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 1987)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1551,14 +1551,19 @@
// TOS(0): return address (Dart code).
void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) {
__ EnterFrame(0);
+ __ pushl(EDX);
__ pushl(ECX);
- __ pushl(EDX);
- __ CallRuntimeFromStub(kBreakpointHandlerRuntimeEntry);
+ __ CallRuntimeFromStub(kBreakpointStaticHandlerRuntimeEntry);
+ __ popl(ECX);
__ popl(EDX);
- __ popl(ECX);
__ LeaveFrame();
- // Now call the static function.
- __ jmp(&StubCode::CallStaticFunctionLabel());
+
+ // Now call the static function. The breakpoint handler function
+ // ensures that the call target is compiled.
+ __ movl(EAX, FieldAddress(ECX, Function::code_offset()));
+ __ movl(ECX, FieldAddress(EAX, Code::instructions_offset()));
+ __ addl(ECX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
+ __ jmp(ECX);
}
@@ -1569,7 +1574,7 @@
__ EnterFrame(0);
__ pushl(ECX);
__ pushl(EDX);
- __ CallRuntimeFromStub(kBreakpointHandlerRuntimeEntry);
+ __ CallRuntimeFromStub(kBreakpointDynamicHandlerRuntimeEntry);
__ popl(EDX);
__ popl(ECX);
__ LeaveFrame();
« runtime/vm/debugger.cc ('K') | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698