Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7300)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 8775059: Relanding http://codereview.chromium.org/8416034 (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Split initialization of BrowserAccessibility tree into pre and post phases. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index 072842c9a87c9c218dc01006ed9bc43297dc91d1..29e302416f4b246448307911263bc4de6606b1cc 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -48,7 +48,7 @@ void BrowserAccessibility::DetachTree(
parent_ = NULL;
}
-void BrowserAccessibility::Initialize(
+void BrowserAccessibility::PreInitialize(
BrowserAccessibilityManager* manager,
BrowserAccessibility* parent,
int32 child_id,
@@ -76,10 +76,23 @@ void BrowserAccessibility::Initialize(
cell_ids_ = src.cell_ids;
unique_cell_ids_ = src.unique_cell_ids;
- Initialize();
+ PreInitialize();
}
-void BrowserAccessibility::Initialize() {
+void BrowserAccessibility::PostInitialize(
+ BrowserAccessibilityManager* manager,
+ BrowserAccessibility* parent,
+ int32 child_id,
+ int32 index_in_parent,
+ const webkit_glue::WebAccessibility& src) {
+ PostInitialize();
+}
+
+void BrowserAccessibility::PreInitialize() {
+ instance_active_ = true;
+}
+
+void BrowserAccessibility::PostInitialize() {
instance_active_ = true;
dmazzoni 2011/12/02 23:33:42 You shouldn't need to do this in PostInitialize.
David Tseng 2011/12/03 00:17:13 Done.
}

Powered by Google App Engine
This is Rietveld 408576698