Relanding http://codereview.chromium.org/8416034

content/browser/accessibility/browser_accessibility.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 #pragma once
 
 #include <map>
 #include <utility>
@@ skipping 37 matching lines @@
 
   virtual ~BrowserAccessibility();
 
   // Detach all descendants of this subtree and push all of the node pointers,
   // including this node, onto the end of |nodes|.
   virtual void DetachTree(std::vector<BrowserAccessibility*>* nodes);
 
   // Perform platform specific initialization. This can be called multiple times
   // during the lifetime of this instance after the members of this base object
   // have been reset with new values from the renderer process.
-  virtual void Initialize();
+  // Perform child independent initialization in this method.
+  virtual void PreInitialize();

[dmazzoni, 2011/12/02 23:33:42]

I think you can make this one protected now, right? The idea is for the Windows
implementation to extend this behavior without needing to take all of the
arguments.

[David Tseng, 2011/12/03 00:17:13]

Done.
On 2011/12/02 23:33:42, Dominic Mazzoni wrote:

+
+  // Perform platform specific initialization. This can be called multiple times
+  // during the lifetime of this instance after the members of this base object
+  // have been reset with new values from the renderer process.
+  // Child dependent initialization can be done here.
+  virtual void PostInitialize();

[dmazzoni, 2011/12/02 23:33:42]

You don't need a non-argument version and a version that takes arguments now,
just one PostInitialize.

[David Tseng, 2011/12/03 00:17:13]

First went for the symetry with PreInitialize. Kept this one and removed the
other.
On 2011/12/02 23:33:42, Dominic Mazzoni wrote:

 
   // Optionally send events triggered simply by the fact that this node
   // has been created or modified (and has been attached to the tree).
   // This can include "show" events, "text changed" events in live regions,
   // or "alert" events.
   virtual void SendNodeUpdateEvents() {}
 
   // Initialize this object, reading attributes from |src|. Does not
   // recurse into children of |src| and build the whole subtree.
-  void Initialize(BrowserAccessibilityManager* manager,
-                  BrowserAccessibility* parent,
-                  int32 child_id,
-                  int32 index_in_parent,
-                  const WebAccessibility& src);
+  void PreInitialize(BrowserAccessibilityManager* manager,
+      BrowserAccessibility* parent,
+      int32 child_id,
+      int32 index_in_parent,
+      const WebAccessibility& src);
+
+  // Initialize this object, reading attributes from |src|. Assumes that
+  // children of |this| have been populated.
+  void PostInitialize(BrowserAccessibilityManager* manager,

[dmazzoni, 2011/12/02 23:33:42]

This shouldn't take any arguments.

[David Tseng, 2011/12/03 00:17:13]

Done; (still needs to be virtual though) so keeping the  other).

On 2011/12/02 23:33:42, Dominic Mazzoni wrote:

+      BrowserAccessibility* parent,
+      int32 child_id,
+      int32 index_in_parent,
+      const WebAccessibility& src);
 
   // Add a child of this object.
   void AddChild(BrowserAccessibility* child);
 
   // Update the parent and index in parent if this node has been moved.
   void UpdateParent(BrowserAccessibility* parent, int index_in_parent);
 
   // Return true if this object is equal to or a descendant of |ancestor|.
   bool IsDescendantOf(BrowserAccessibility* ancestor);
 
@@ skipping 187 matching lines @@
   // tree, a client may still be holding onto a pointer to this object, so
   // we mark it as inactive so that calls to any of this object's methods
   // immediately return failure.
   bool instance_active_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility);
 };
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_