Issue 8775049: Split Dr.Memory suppressions into two parts: lightmode-only and all the others

Issue 8775049: Split Dr.Memory suppressions into two parts: lightmode-only and all the others (Closed)

Created:
9 years ago by Timur Iskhodzhanov

Modified:
9 years ago

Reviewers:
Reid Kleckner, Derek Bruening

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Reid Kleckner

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Split Dr.Memory suppressions into two parts: lightmode-only and all the others This should improve maintainability, performance [a bit]. Also, when we start fixing the "full" mode we won't break the light mode suppression file. TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112685

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -965 lines)			Patch
M	tools/valgrind/drmemory/suppressions.txt	View	1 2	3 chunks	+32 lines, -710 lines	0 comments	Download
A +	tools/valgrind/drmemory/suppressions_full.txt	View	1 2	13 chunks	+51 lines, -254 lines	0 comments	Download
M	tools/valgrind/valgrind_test.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

TBR http://codereview.chromium.org/8775049/diff/1004/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (left): http://codereview.chromium.org/8775049/diff/1004/tools/valgrind/drmemory/suppressions.txt#oldcode526 tools/valgrind/drmemory/suppressions.txt:526: UNADDRESSABLE ACCESS this looks like fixed http://codereview.chromium.org/8775049/diff/1004/tools/valgrind/drmemory/suppressions.txt#oldcode773 tools/valgrind/drmemory/suppressions.txt:773: ...

9 years ago (2011-12-02 13:10:52 UTC) #1

Reid Kleckner

9 years ago (2011-12-02 14:41:00 UTC) #2

LGTM

http://codereview.chromium.org/8775049/diff/1004/tools/valgrind/drmemory/supp...
File tools/valgrind/drmemory/suppressions_full.txt (right):

http://codereview.chromium.org/8775049/diff/1004/tools/valgrind/drmemory/supp...
tools/valgrind/drmemory/suppressions_full.txt:124: # TODO(timurrrr): I'm too
lazy to add name= to all the suppressions below now.
s/# (http://code.*)\n(.*)\n/\2\nname=\1\n/
:)

Expand Messages | Collapse Messages