Issue 8775047: Add support for overridable DRMEMORY_COMMAND in tools/valgrind/chrome_tests.bat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8775047: Add support for overridable DRMEMORY_COMMAND in tools/valgrind/chrome_tests.bat (Closed)

Created:
9 years ago by Timur Iskhodzhanov

Modified:
9 years ago

Reviewers:
Reid Kleckner, Derek Bruening

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add support for overridable DRMEMORY_COMMAND in tools/valgrind/chrome_tests.bat Also, add a few minor refinements to the other parts of the script TBR=bruening,rnk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112670

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
	M	tools/valgrind/chrome_tests.bat	View		4 chunks	+11 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

Reid Kleckner

9 years ago (2011-12-02 14:43:49 UTC) #2

LGTM

If I had to pick between an environment var and a flag I'd choose a flag, but
whatever works.