Bookmark name inputs should only allow single-line input

Bookmark name inputs should only allow single-line input

- both BookmarkBubble and BookmarkEditor now use single-line input for their names
- update nib to use IBOutlet to call the NSCell off of the NSTextField

BUG=100618
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112846

[KushalP, 2011-12-02 01:36:11]

I tried to remove the warning that is appearing for "This view is clipping its
content", but my fix messes with the layout of the UI elements.

As stated by Nico on IRC, this appears due to internationalisation naming of
elements.

[Ilya Sherman, 2011-12-02 09:56:45]

L G T M.  Please wait for Mike's review as well, though, just to double check.

[KushalP, 2011-12-02 13:07:58]

On 2011/12/02 09:56:45, Ilya Sherman wrote:
> L G T M.  Please wait for Mike's review as well, though, just to double check.

Great, thanks Ilya.

Something I'm slightly worried about is the lack of tests for the two recent UI
changes I've made in ui/cocoa/bookmarks. I know that the models themselves
handle this internally and have tests, but it would be nice to make sure that
the input boxes are working as expected.

1. Is the above necessary? Or am I over-thinking things
2. If I should do it, should it be part of this change, or another CL?

[KushalP, 2011-12-02 13:15:21]

The other thing I've been wondering is whether I should pull the
setUsesSingleLineMode blocks of code into a function. Then it could just exist
as setCellToSingleLineMode([textField cell]). What do you think?

[mrossetti, 2011-12-02 15:52:22]

LGTM with a couple of minor suggestions. (We should also add TODO's for the
similar changes in bookmark_name_folder_controller.mm and
bookmark_editor_base_controller.mm when convenient. Sorry I missed that
suggestion.)

http://codereview.chromium.org/8775042/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

http://codereview.chromium.org/8775042/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:112: // only
10.6 and greater support the setUsesSingleLineMode method.
Add a TODO(kushalp): to this comment as you will want to remember to remove this
once we get to a 10.6+ only state.

http://codereview.chromium.org/8775042/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm (right):

http://codereview.chromium.org/8775042/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm:52: // Check if
NSTextFieldCell supports the method. This check is in place as
Add TODO(kushalp): here, too.

[KushalP, 2011-12-02 17:58:31]

Updated with new Patch Set containing TODO comments for a 10.6+ future.

[mrossetti, 2011-12-02 21:01:44]

Still LGTM! Engage!

[KushalP, 2011-12-02 21:08:26]

On 2011/12/02 21:01:44, mrossetti wrote:
> Still LGTM! Engage!

Preparing to engage... SWOOOOSH.

[commit-bot: I haz the power, 2011-12-02 21:08:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kushi.p@gmail.com/8775042/7

[commit-bot: I haz the power, 2011-12-02 23:51:54]

Try job failure for 8775042-7 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[KushalP, 2011-12-02 23:56:54]

On 2011/12/02 23:51:54, I haz the power (commit-bot) wrote:
> Try job failure for 8775042-7 (retry) on win_rel for step "browser_tests".
> It's a second try, previously, step "browser_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

That doesn't look like it's me. Is it?

[mrossetti, 2011-12-02 23:59:25]

Nope. I'd suggest a manual commit.

On Fri, Dec 2, 2011 at 4:56 PM, <kushi.p@gmail.com> wrote:

> On 2011/12/02 23:51:54, I haz the power (commit-bot) wrote:
>
>> Try job failure for 8775042-7 (retry) on win_rel for step "browser_tests".
>> It's a second try, previously, step "browser_tests" failed.
>>
>
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=win_rel&**number=3348<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3348>
>
> That doesn't look like it's me. Is it?
>
>
http://codereview.chromium.**org/8775042/<http://codereview.chromium.org/8775...
>

[commit-bot: I haz the power, 2011-12-03 00:01:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kushi.p@gmail.com/8775042/7

[KushalP, 2011-12-03 00:01:35]

On 2011/12/02 23:59:25, mrossetti wrote:
> Nope. I'd suggest a manual commit.

I don't have commit rights to the project. I've checked the commit box again to
see if third-time-lucky solves it.

[mrossetti, 2011-12-03 00:14:45]

Let me know if it doesn't work. In that case, I'll commit for you as soon
as I can (but it might not be until Monday).

On Fri, Dec 2, 2011 at 5:01 PM, <kushi.p@gmail.com> wrote:

> On 2011/12/02 23:59:25, mrossetti wrote:
>
>> Nope. I'd suggest a manual commit.
>>
>
> I don't have commit rights to the project. I've checked the commit box
> again to
> see if third-time-lucky solves it.
>
>
http://codereview.chromium.**org/8775042/<http://codereview.chromium.org/8775...
>

[commit-bot: I haz the power, 2011-12-03 01:56:53]

Change committed as 112846