Add Dart_IsExternalString and Dart_ExternalStringGetPeer to the dart

runtime/vm/object.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "vm/assert.h"
 #include "vm/dart.h"
 #include "vm/globals.h"
@@ skipping 2445 matching lines @@
   virtual bool Equals(const Instance& other) const;
 
   intptr_t CompareTo(const String& other) const;
 
   bool StartsWith(const String& other) const;
 
   virtual RawInstance* Canonicalize() const;
 
   bool IsSymbol() const;
 
+  virtual bool IsExternal() const { return false; }
+  virtual void* GetPeer() const {
+    UNREACHABLE();
+    return NULL;
+  }
+
   static RawString* New(const char* str, Heap::Space space = Heap::kNew);
   static RawString* New(const uint8_t* characters,
                         intptr_t len,
                         Heap::Space space = Heap::kNew);
   static RawString* New(const uint16_t* characters,
                         intptr_t len,
                         Heap::Space space = Heap::kNew);
   static RawString* New(const uint32_t* characters,
                         intptr_t len,
                         Heap::Space space = Heap::kNew);
@@ skipping 260 matching lines @@
   }
 
   virtual intptr_t CharSize() const {
     return kOneByteChar;
   }
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawExternalOneByteString));
   }
 
+  virtual bool IsExternal() const { return true; }
+  virtual void* GetPeer() const {
+    return raw_ptr()->external_data_->peer_;

[siva, 2011/12/02 01:53:01]

Not sure what the official C++ style guide says but we have always tried to club
the 'static' methods together, so in this case the method InstanceSize would be
after these two functions.

[turnidge, 2011/12/05 17:54:28]

Done.

+  }
+
   static RawExternalOneByteString* New(const uint8_t* characters,
                                        intptr_t len,
                                        void* peer,
                                        PeerFinalizer callback,
                                        Heap::Space space);
 
  private:
   const uint8_t* CharAddr(intptr_t index) const {
     // TODO(iposva): Determine if we should throw an exception here.
     ASSERT((index >= 0) && (index < Length()));
@@ skipping 17 matching lines @@
   }
 
   virtual intptr_t CharSize() const {
     return kTwoByteChar;
   }
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawExternalTwoByteString));
   }
 
+  virtual bool IsExternal() const { return true; }
+  virtual void* GetPeer() const {
+    return raw_ptr()->external_data_->peer_;
+  }
+
   static RawExternalTwoByteString* New(const uint16_t* characters,
                                        intptr_t len,
                                        void* peer,
                                        PeerFinalizer callback,
                                        Heap::Space space = Heap::kNew);
 
  private:
   const uint16_t* CharAddr(intptr_t index) const {
     // TODO(iposva): Determine if we should throw an exception here.
     ASSERT((index >= 0) && (index < Length()));
@@ skipping 17 matching lines @@
   }
 
   virtual intptr_t CharSize() const {
     return kFourByteChar;
   }
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawExternalFourByteString));
   }
 
+  virtual bool IsExternal() const { return true; }
+  virtual void* GetPeer() const {
+    return raw_ptr()->external_data_->peer_;
+  }
+
   static RawExternalFourByteString* New(const uint32_t* characters,
                                         intptr_t len,
                                         void* peer,
                                         PeerFinalizer callback,
                                         Heap::Space space = Heap::kNew);
 
  private:
   const uint32_t* CharAddr(intptr_t index) const {
     // TODO(iposva): Determine if we should throw an exception here.
     ASSERT((index >= 0) && (index < Length()));
@@ skipping 405 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_